Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storybook): removing support for Storybook 5 #9380

Merged
merged 1 commit into from
Apr 12, 2022

Conversation

mandarini
Copy link
Member

@mandarini mandarini commented Mar 17, 2022

Removing support for Storybook v5.

It's not being supported already, actually, since if you're on Nx version 13.4 and on, there would be incompatibilities with webpack (for React) and Angular 13.1.

So, removing all generators, and double files, and adding migrators to automatically run our two Storybook generators (migrate-defaults and migrate-stories-to-6-2).

This is for version 14.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@mandarini mandarini self-assigned this Mar 17, 2022
@nx-cloud
Copy link

nx-cloud bot commented Mar 17, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ad28d7e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 13 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Mar 17, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/BdPT911NxsEKYCLt7TRSfJag1QGr
✅ Preview: https://nx-dev-git-fork-mandarini-feat-remove-storybookv5-support-nrwl.vercel.app

[Deployment for ad28d7e canceled]

@mandarini mandarini force-pushed the feat/remove-storybookv5-support branch from ab88d00 to 6116911 Compare March 18, 2022 14:52
@mandarini mandarini force-pushed the feat/remove-storybookv5-support branch from 6116911 to e67ed54 Compare March 18, 2022 15:01
@mandarini mandarini force-pushed the feat/remove-storybookv5-support branch from e67ed54 to 91d22bc Compare March 18, 2022 15:22
@mandarini mandarini force-pushed the feat/remove-storybookv5-support branch from 91d22bc to fc3fb02 Compare March 28, 2022 11:25
@mandarini mandarini force-pushed the feat/remove-storybookv5-support branch from 53a3df9 to 01ebb9d Compare March 28, 2022 17:08
@mandarini mandarini added the scope: storybook Issues related to Storybook support in Nx label Mar 29, 2022
@mandarini mandarini force-pushed the feat/remove-storybookv5-support branch from 01ebb9d to a1fd4e5 Compare March 29, 2022 11:37
@mandarini mandarini force-pushed the feat/remove-storybookv5-support branch 2 times, most recently from 2a7408c to 90d3e40 Compare March 29, 2022 11:40
@mandarini mandarini force-pushed the feat/remove-storybookv5-support branch from 90d3e40 to 85a6660 Compare March 31, 2022 15:19
@mandarini mandarini force-pushed the feat/remove-storybookv5-support branch from 85a6660 to b02f1cb Compare April 5, 2022 15:41
@mandarini mandarini force-pushed the feat/remove-storybookv5-support branch from b02f1cb to 38a0eb2 Compare April 6, 2022 12:28
@mandarini mandarini force-pushed the feat/remove-storybookv5-support branch from 38a0eb2 to 39b3870 Compare April 6, 2022 17:40
Copy link
Contributor

@Coly010 Coly010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: storybook Issues related to Storybook support in Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants