-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(storybook): removing support for Storybook 5 #9380
feat(storybook): removing support for Storybook 5 #9380
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nrwl/nx-dev/BdPT911NxsEKYCLt7TRSfJag1QGr [Deployment for ad28d7e canceled] |
ab88d00
to
6116911
Compare
6116911
to
e67ed54
Compare
e67ed54
to
91d22bc
Compare
91d22bc
to
fc3fb02
Compare
53a3df9
to
01ebb9d
Compare
01ebb9d
to
a1fd4e5
Compare
2a7408c
to
90d3e40
Compare
90d3e40
to
85a6660
Compare
85a6660
to
b02f1cb
Compare
b02f1cb
to
38a0eb2
Compare
38a0eb2
to
39b3870
Compare
39b3870
to
c31374b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉
c31374b
to
ad28d7e
Compare
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Removing support for Storybook v5.
It's not being supported already, actually, since if you're on Nx version 13.4 and on, there would be incompatibilities with webpack (for React) and Angular 13.1.
So, removing all generators, and double files, and adding migrators to automatically run our two Storybook generators (migrate-defaults and migrate-stories-to-6-2).
This is for version
14
.Current Behavior
Expected Behavior
Related Issue(s)
Fixes #