-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not able to build project's that have buildable dependencies without package.json
's
#8707
Comments
@AgentEnder is this something that can be fixed on nx-dotnet's side? |
Not really, we should be checking that the lib actually has a package.json and skipping it if it doesn't on the NX side, should be easy fix. If you want to open a PR it looks like you've already identified the piece of code, and I could review. |
hey @AgentEnder 👋 can we get this merged? |
Hey, sorry. Yeah, let me take a look. |
This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context. |
Current Behavior
calculateProjectDependencies fails when buildable dependencies don't have
package.json
'sExpected Behavior
Build should work as expected.
Steps to Reproduce
@nrwl/js:tsc
library named target-libpackage.json
named dep-lib (e.g., create a dotnet project using the nx-dotnet plugin)nx build target-lib
Failure Logs
Environment
Context
nx/packages/workspace/src/utilities/buildable-libs-utils.ts
Lines 45 to 47 in b23f2d8
The text was updated successfully, but these errors were encountered: