-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot run jest tests with --maxWorkers=50%
option via @nrwl/jest:jest builder
#2871
Labels
community
This is a good first issue for contributing
outdated
scope: testing tools
Issues related to Cypress / Jest / Playwright / Vitest support in Nx
type: feature
Comments
FrozenPandaz
added
community
This is a good first issue for contributing
scope: testing tools
Issues related to Cypress / Jest / Playwright / Vitest support in Nx
type: feature
labels
May 1, 2020
Thanks for reporting this! Looks like the type of the option needs to be This would be a good first issue. |
I'd be happy to submit a PR for review! |
wrslatz
added a commit
to wrslatz/nx
that referenced
this issue
May 17, 2020
… type Jest supports both number and string args for the maxWorkers option, per their latest docs. This updates the options for the jest builder to support both number and string types. Also updates the docs accordingly. ISSUES CLOSED: nrwl#2871
wrslatz
added a commit
to wrslatz/nx
that referenced
this issue
May 17, 2020
… type Jest supports both number and string args for the maxWorkers option, per their latest docs. This updates the options for the jest builder to support both number and string types. Also updates the docs accordingly. ISSUES CLOSED: nrwl#2871
wrslatz
added a commit
to wrslatz/nx
that referenced
this issue
May 17, 2020
… type Jest supports both number and string args for the maxWorkers option, per their latest docs. This updates the options for the jest builder to support both number and string types. Also updates the docs accordingly. ISSUES CLOSED: nrwl#2871
I've submitted #3025 to close this issue. Would appreciate a review whenever it's convenient! |
FrozenPandaz
pushed a commit
that referenced
this issue
May 23, 2020
… type (#3025) * fix(testing): update maxWorkers jest builder option to support string type Jest supports both number and string args for the maxWorkers option, per their latest docs. This updates the options for the jest builder to support both number and string types. Also updates the docs accordingly. ISSUES CLOSED: #2871 * fix(testing): fix test expectation missing property
This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
community
This is a good first issue for contributing
outdated
scope: testing tools
Issues related to Cypress / Jest / Playwright / Vitest support in Nx
type: feature
The
@nrwl/jest
builder should support both number and string inputs formaxWorkers
config option. Passing--maxWorkers=50%
tong test
ornx affected:test
fails with schema validation, but the Jest CLI Options documentation specify that both a number and string are acceptable arguments.Expected Behavior
Both
ng test -- --maxWorkers=50%
andnx affected:test -- --maxWorkers=50%
run tests and do not throw schema validation errors.Current Behavior
Both
ng test -- --maxWorkers=50%
andnx affected:test -- --maxWorkers=50%
result in the following error:Failure Information (for bugs)
Please help provide information about the failure if this is a bug. If it is not a bug, please remove the rest of this template.
Steps to Reproduce
npx create-nx-workspace@latest
"builder": "@nrwl/jest:jest"
and pass-- --maxWorkers=50%
flag to the command.Context
The schema that is now out of date
nx/packages/jest/src/builders/jest/schema.json
Lines 56 to 59 in 54d06f0
The original PR that implemented this functionality
#757
The latest jest docs for this functionality
https://jestjs.io/docs/en/cli#--maxworkersnumstring
Minimal reproduction repo
https://github.com/wrslatz/nx-playground/tree/e836200fe7484c6ac022066d13d534f5eb95808b
The text was updated successfully, but these errors were encountered: