Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nx release changelog should support non github.com remotes #21906

Closed
1 task
jaknas opened this issue Feb 21, 2024 · 6 comments
Closed
1 task

nx release changelog should support non github.com remotes #21906

jaknas opened this issue Feb 21, 2024 · 6 comments

Comments

@jaknas
Copy link

jaknas commented Feb 21, 2024

Description

Currently when trying to run nx release with projectChangelogs.createRelease = 'github' option, I'm getting:

Unable to create a GitHub release because the GitHub repo slug could not be determined.

My git remote -v returns format like this: [email protected]:ACME/REPO.git

Motivation

This is something that's built-in with Lerna and works great. Would love to have this feature in Nx so I can migrate to using nx release.

Suggested Implementation

It should be able to automatically deduce if remote is not github.com and for e.g uses github enterprise.

Alternate Implementations

Allow for configuration via programatic API or nx.json

@zachlewton
Copy link

zachlewton commented Apr 29, 2024

just curious if there was any plans to add this feature, currently setting up some pipelines in an enterprise github repo and i am not able to use the github release features or have the changelog commits resolve.
really enjoying using the release api btw, awesome product !

@pcopley
Copy link

pcopley commented May 3, 2024

I was about to submit a PR that addresses this issue for GitHub Enterprise instances (which have a similar issue), I will see if I can easily extend it to handle this use case.

pcopley added a commit to pcopley/nx that referenced this issue May 4, 2024
Updates remote URL regex to match on GitHub, GitHub Enterprise, and local git repositories.

Closes nrwl#23178
Closes nrwl#21906
@JamesHenry
Copy link
Collaborator

Hi Folks,

I have put up a draft PR which adds support for GitHub Enterprise Server: #26482

I am not fully happy with the implementation details and may do some more refactoring, but functionally it should be just about there.

Are you willing to help me test it out on your repo please? Have you ever done a local build of Nx and applied things that way?

@JamesHenry
Copy link
Collaborator

Hi again folks,

Good news, we now have the capability to create npm releases for PRs for testing purposes. This is something we will use very sparingly to avoid confusion, but for something like this it's a perfect solution because it's a real npm version that you can install and commit as needed, and you don't need to do any local builds of this repo.

Please see the comment here for details, and let me know how you get on with testing it:

#26482 (comment)

Many thanks 🙏

Copy link

This issue has been automatically marked as stale because it hasn't had any activity for 6 months.
Many things may have changed within this time. The issue may have already been fixed or it may not be relevant anymore.
If at this point, this is still an issue, please respond with updated information.
It will be closed in 21 days if no further activity occurs.
Thanks for being a part of the Nx community! 🙏

@github-actions github-actions bot added the stale label Dec 11, 2024
@JamesHenry
Copy link
Collaborator

We landed support for GitHub enterprise server a while ago this one just didn’t get closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants