-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nx release changelog
should support non github.com
remotes
#21906
Comments
just curious if there was any plans to add this feature, currently setting up some pipelines in an enterprise github repo and i am not able to use the github release features or have the changelog commits resolve. |
I was about to submit a PR that addresses this issue for GitHub Enterprise instances (which have a similar issue), I will see if I can easily extend it to handle this use case. |
Updates remote URL regex to match on GitHub, GitHub Enterprise, and local git repositories. Closes nrwl#23178 Closes nrwl#21906
Hi Folks, I have put up a draft PR which adds support for GitHub Enterprise Server: #26482 I am not fully happy with the implementation details and may do some more refactoring, but functionally it should be just about there. Are you willing to help me test it out on your repo please? Have you ever done a local build of Nx and applied things that way? |
Hi again folks, Good news, we now have the capability to create npm releases for PRs for testing purposes. This is something we will use very sparingly to avoid confusion, but for something like this it's a perfect solution because it's a real npm version that you can install and commit as needed, and you don't need to do any local builds of this repo. Please see the comment here for details, and let me know how you get on with testing it: Many thanks 🙏 |
This issue has been automatically marked as stale because it hasn't had any activity for 6 months. |
We landed support for GitHub enterprise server a while ago this one just didn’t get closed |
Description
Currently when trying to run
nx release
withprojectChangelogs.createRelease = 'github'
option, I'm getting:My
git remote -v
returns format like this:[email protected]:ACME/REPO.git
Motivation
This is something that's built-in with Lerna and works great. Would love to have this feature in Nx so I can migrate to using
nx release
.Suggested Implementation
It should be able to automatically deduce if remote is not
github.com
and for e.g uses github enterprise.Alternate Implementations
Allow for configuration via programatic API or
nx.json
The text was updated successfully, but these errors were encountered: