fix(react): update migration to work without targets (#9901)

nrwl · Apr 20, 2022 · e744768 · e744768
1 parent a1326ae
commit e744768
Show file tree

Hide file tree

Showing 4 changed files with 46 additions and 4 deletions.
diff --git a/packages/next/src/migrations/update-14-0-0/add-default-development-configurations.spec.ts b/packages/next/src/migrations/update-14-0-0/add-default-development-configurations.spec.ts
@@ -41,4 +41,25 @@ describe('React default development configuration', () => {
       dev: true,
     });
   });
+
+  it('should work without targets', async () => {
+    const tree = createTreeWithEmptyWorkspace(2);
+    addProjectConfiguration(
+      tree,
+      'example',
+      {
+        root: 'apps/example',
+        projectType: 'application',
+      },
+      true
+    );
+
+    await update(tree);
+
+    const config = readProjectConfiguration(tree, 'example');
+    expect(config).toEqual({
+      root: 'apps/example',
+      projectType: 'application',
+    });
+  });
 });
diff --git a/packages/next/src/migrations/update-14-0-0/add-default-development-configurations.ts b/packages/next/src/migrations/update-14-0-0/add-default-development-configurations.ts
@@ -10,13 +10,13 @@ export async function update(tree: Tree) {
 
   projects.forEach((config, name) => {
     let shouldUpdate = false;
-    if (config.targets.build?.executor === '@nrwl/next:build') {
+    if (config.targets?.build?.executor === '@nrwl/next:build') {
       shouldUpdate = true;
       config.targets.build.defaultConfiguration ??= 'production';
       config.targets.build.configurations.development ??= {};
     }
 
-    if (config.targets.serve?.executor === '@nrwl/next:server') {
+    if (config.targets?.serve?.executor === '@nrwl/next:server') {
       shouldUpdate = true;
       config.targets.serve.defaultConfiguration ??= 'development';
       config.targets.serve.configurations.development ??= {

diff --git a/packages/react/src/migrations/update-14-0-0/add-default-development-configurations.spec.ts b/packages/react/src/migrations/update-14-0-0/add-default-development-configurations.spec.ts
@@ -45,4 +45,25 @@ describe('React default development configuration', () => {
       buildTarget: `example:build:development`,
     });
   });
+
+  it('should work without targets', async () => {
+    const tree = createTreeWithEmptyWorkspace(2);
+    addProjectConfiguration(
+      tree,
+      'example',
+      {
+        root: 'apps/example',
+        projectType: 'application',
+      },
+      true
+    );
+
+    await update(tree);
+
+    const config = readProjectConfiguration(tree, 'example');
+    expect(config).toEqual({
+      root: 'apps/example',
+      projectType: 'application',
+    });
+  });
 });
diff --git a/packages/react/src/migrations/update-14-0-0/add-default-development-configurations.ts b/packages/react/src/migrations/update-14-0-0/add-default-development-configurations.ts
@@ -10,7 +10,7 @@ export async function update(tree: Tree) {
 
   projects.forEach((config, name) => {
     let shouldUpdate = false;
-    if (config.targets.build?.executor === '@nrwl/web:webpack') {
+    if (config.targets?.build?.executor === '@nrwl/web:webpack') {
       shouldUpdate = true;
       config.targets.build.defaultConfiguration ??= 'production';
       config.targets.build.configurations.development ??= {
@@ -21,7 +21,7 @@ export async function update(tree: Tree) {
       };
     }
 
-    if (config.targets.serve?.executor === '@nrwl/web:dev-server') {
+    if (config.targets?.serve?.executor === '@nrwl/web:dev-server') {
       shouldUpdate = true;
       config.targets.serve.defaultConfiguration ??= 'development';
       config.targets.serve.configurations.development ??= {