fix(linter): do not break migration if eslint file is missing

nrwl · Aug 22, 2023 · d019de0 · d019de0
1 parent 231a998
commit d019de0
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 10 deletions.
diff --git a/packages/linter/src/generators/init/init-migration.ts b/packages/linter/src/generators/init/init-migration.ts
@@ -26,24 +26,24 @@ export function migrateConfigToMonorepoStyle(
   projects.forEach((project) => {
     const lintTarget = findLintTarget(project);
     if (lintTarget) {
-      const projectEslintPath = joinPathFragments(
-        project.root,
-        lintTarget.options.eslintConfig || findEslintFile(tree, project.root)
-      );
-      migrateEslintFile(projectEslintPath, tree);
+      const eslintFile =
+        lintTarget.options.eslintConfig || findEslintFile(tree, project.root);
+      if (eslintFile) {
+        const projectEslintPath = joinPathFragments(project.root, eslintFile);
+        migrateEslintFile(projectEslintPath, tree);
+      }
     }
   });
 }
 
 export function findLintTarget(
   project: ProjectConfiguration
 ): TargetConfiguration {
-  return Object.entries(project.targets ?? {}).find(
-    ([name, target]) =>
-      name === 'lint' ||
+  return Object.values(project.targets ?? {}).find(
+    (target) =>
       target.executor === '@nx/linter:eslint' ||
       target.executor === '@nrwl/linter:eslint'
-  )?.[1];
+  );
 }
 
 function migrateEslintFile(projectEslintPath: string, tree: Tree) {
@@ -99,6 +99,6 @@ function migrateEslintFile(projectEslintPath: string, tree: Tree) {
     console.warn('YAML eslint config is not supported yet for migration');
   }
   if (projectEslintPath.endsWith('.js') || projectEslintPath.endsWith('.cjs')) {
-    console.warn('YAML eslint config is not supported yet for migration');
+    console.warn('JS eslint config is not supported yet for migration');
   }
 }
diff --git a/packages/linter/src/generators/utils/eslint-file.ts b/packages/linter/src/generators/utils/eslint-file.ts
@@ -11,11 +11,15 @@ export const eslintConfigFileWhitelist = [
 ];
 
 export const baseEsLintConfigFile = '.eslintrc.base.json';
+export const baseEsLintFlatConfigFile = 'eslint.base.config.js';
 
 export function findEslintFile(tree: Tree, projectRoot = ''): string | null {
   if (projectRoot === '' && tree.exists(baseEsLintConfigFile)) {
     return baseEsLintConfigFile;
   }
+  if (projectRoot === '' && tree.exists(baseEsLintFlatConfigFile)) {
+    return baseEsLintFlatConfigFile;
+  }
   for (const file of eslintConfigFileWhitelist) {
     if (tree.exists(joinPathFragments(projectRoot, file))) {
       return file;