chore(react-native): remove deprecated options in the code (#19665)

nrwl · Oct 17, 2023 · aaea8f9 · aaea8f9 · vercel · Oct 17, 2023
1 parent 476e13d
commit aaea8f9
Show file tree

Hide file tree

Showing 11 changed files with 15 additions and 86 deletions.
diff --git a/docs/generated/packages/react-native/executors/run-android.json b/docs/generated/packages/react-native/executors/run-android.json
@@ -54,11 +54,6 @@
         "examples": ["debug", "release"],
         "x-priority": "important"
       },
-      "packager": {
-        "type": "boolean",
-        "description": "Launch packager while building",
-        "default": true
-      },
       "port": {
         "type": "number",
         "description": "The port where the packager server is listening on.",
@@ -95,12 +90,6 @@
         "type": "boolean",
         "description": "Explicitly select build type and flavour to use before running a build"
       },
-      "sync": {
-        "type": "boolean",
-        "description": "Syncs npm dependencies to `package.json` (for React Native autolink).",
-        "x-deprecated": "Add sync-deps to dependsOn for this target in project.json instead",
-        "default": true
-      },
       "resetCache": {
         "type": "boolean",
         "description": "Resets metro cache.",

diff --git a/docs/generated/packages/react-native/executors/run-ios.json b/docs/generated/packages/react-native/executors/run-ios.json
@@ -76,28 +76,11 @@
         ],
         "description": "Custom params that will be passed to xcodebuild command."
       },
-      "install": {
-        "type": "boolean",
-        "description": "Runs `pod install` for native modules before building iOS app.",
-        "default": true,
-        "x-deprecated": "Add `pod-install` to dependsOn for this target in project.json instead."
-      },
-      "sync": {
-        "type": "boolean",
-        "description": "Syncs npm dependencies to `package.json` (for React Native autolink).",
-        "x-deprecated": "Add `sync-deps` to dependsOn for this target in project.json instead.",
-        "default": true
-      },
       "resetCache": {
         "type": "boolean",
         "description": "Resets metro cache.",
         "default": false
       },
-      "packager": {
-        "type": "boolean",
-        "description": "Launch packager while building",
-        "default": true
-      },
       "binaryPath": {
         "type": "string",
         "description": "Path relative to project root where pre-built .app binary lives."

diff --git a/packages/expo/src/executors/run/run.impl.ts b/packages/expo/src/executors/run/run.impl.ts
@@ -88,7 +88,7 @@ function runCliRun(
   });
 }
 
-const nxOptions = ['sync', 'platform', 'install', 'clean'];
+const nxOptions = ['platform', 'clean'];
 const iOSOptions = ['xcodeConfiguration', 'schema'];
 const androidOptions = ['variant'];
 /*

diff --git a/packages/expo/src/generators/application/files/metro.config.js.template b/packages/expo/src/generators/application/files/metro.config.js.template
@@ -20,7 +20,7 @@ const customConfig = {
     assetExts: assetExts.filter((ext) => ext !== 'svg'),
     sourceExts: [...sourceExts, 'svg'],
     blockList: exclusionList([/^(?!.*node_modules).*\/dist\/.*/]),
-    unstable_enableSymlinks: true,
+    // unstable_enableSymlinks: true,
     // unstable_enablePackageExports: true,
   },
 };

diff --git a/packages/react-native/src/executors/build-android/build-android.impl.ts b/packages/react-native/src/executors/build-android/build-android.impl.ts
@@ -66,14 +66,8 @@ function runCliBuild(
   });
 }
 
-const nxOptions = ['sync', 'packager'];
 const startOptions = ['port', 'resetCache'];
-const deprecatedOptions = ['apk', 'debug', 'gradleTask'];
 
 function createBuildAndroidOptions(options: ReactNativeBuildAndroidOptions) {
-  return getCliOptions<ReactNativeBuildAndroidOptions>(options, [
-    ...nxOptions,
-    ...startOptions,
-    ...deprecatedOptions,
-  ]);
+  return getCliOptions<ReactNativeBuildAndroidOptions>(options, startOptions);
 }
diff --git a/packages/react-native/src/executors/build-ios/build-ios.impl.ts b/packages/react-native/src/executors/build-ios/build-ios.impl.ts
@@ -68,13 +68,10 @@ function runCliBuildIOS(
   });
 }
 
-const nxOptions = ['sync', 'install', 'packager'];
 const startOptions = ['port', 'resetCache'];
 
 function createBuildIOSOptions(options: ReactNativeBuildIosOptions) {
-  return getCliOptions<ReactNativeBuildIosOptions>(
-    options,
-    [...nxOptions, ...startOptions],
-    ['buildFolder']
-  );
+  return getCliOptions<ReactNativeBuildIosOptions>(options, startOptions, [
+    'buildFolder',
+  ]);
 }
diff --git a/packages/react-native/src/executors/run-android/run-android.impl.ts b/packages/react-native/src/executors/run-android/run-android.impl.ts
@@ -92,14 +92,12 @@ function runCliRunAndroid(
   });
 }
 
-const nxOptions = ['sync', 'packager'];
 const startOptions = ['port', 'resetCache'];
-const deprecatedOptions = ['variant', 'jetifier'];
 
 function createRunAndroidOptions(options: ReactNativeRunAndroidOptions) {
-  return getCliOptions<ReactNativeRunAndroidOptions>(
-    options,
-    [...nxOptions, ...startOptions, ...deprecatedOptions],
-    ['appId', 'appIdSuffix', 'deviceId']
-  );
+  return getCliOptions<ReactNativeRunAndroidOptions>(options, startOptions, [
+    'appId',
+    'appIdSuffix',
+    'deviceId',
+  ]);
 }
diff --git a/packages/react-native/src/executors/run-android/schema.json b/packages/react-native/src/executors/run-android/schema.json
@@ -54,11 +54,6 @@
       "examples": ["debug", "release"],
       "x-priority": "important"
     },
-    "packager": {
-      "type": "boolean",
-      "description": "Launch packager while building",
-      "default": true
-    },
     "port": {
       "type": "number",
       "description": "The port where the packager server is listening on.",
@@ -95,12 +90,6 @@
       "type": "boolean",
       "description": "Explicitly select build type and flavour to use before running a build"
     },
-    "sync": {
-      "type": "boolean",
-      "description": "Syncs npm dependencies to `package.json` (for React Native autolink).",
-      "x-deprecated": "Add sync-deps to dependsOn for this target in project.json instead",
-      "default": true
-    },
     "resetCache": {
       "type": "boolean",
       "description": "Resets metro cache.",

diff --git a/packages/react-native/src/executors/run-ios/run-ios.impl.ts b/packages/react-native/src/executors/run-ios/run-ios.impl.ts
@@ -92,14 +92,10 @@ function runCliRunIOS(
   });
 }
 
-const nxOptions = ['sync', 'install', 'packager'];
 const startOptions = ['port', 'resetCache'];
-const deprecatedOptions = ['xcodeConfiguration'];
 
 function createRunIOSOptions(options: ReactNativeRunIosOptions) {
-  return getCliOptions<ReactNativeRunIosOptions>(
-    options,
-    [...nxOptions, ...startOptions, ...deprecatedOptions],
-    ['buildFolder']
-  );
+  return getCliOptions<ReactNativeRunIosOptions>(options, startOptions, [
+    'buildFolder',
+  ]);
 }
diff --git a/packages/react-native/src/executors/run-ios/schema.json b/packages/react-native/src/executors/run-ios/schema.json
@@ -82,28 +82,11 @@
       ],
       "description": "Custom params that will be passed to xcodebuild command."
     },
-    "install": {
-      "type": "boolean",
-      "description": "Runs `pod install` for native modules before building iOS app.",
-      "default": true,
-      "x-deprecated": "Add `pod-install` to dependsOn for this target in project.json instead."
-    },
-    "sync": {
-      "type": "boolean",
-      "description": "Syncs npm dependencies to `package.json` (for React Native autolink).",
-      "x-deprecated": "Add `sync-deps` to dependsOn for this target in project.json instead.",
-      "default": true
-    },
     "resetCache": {
       "type": "boolean",
       "description": "Resets metro cache.",
       "default": false
     },
-    "packager": {
-      "type": "boolean",
-      "description": "Launch packager while building",
-      "default": true
-    },
     "binaryPath": {
       "type": "string",
       "description": "Path relative to project root where pre-built .app binary lives."

diff --git a/packages/react-native/src/generators/application/files/app/metro.config.js.template b/packages/react-native/src/generators/application/files/app/metro.config.js.template
@@ -19,7 +19,7 @@ const customConfig = {
     assetExts: assetExts.filter((ext) => ext !== 'svg'),
     sourceExts: [...sourceExts, 'svg'],
     blockList: exclusionList([/^(?!.*node_modules).*\/dist\/.*/]),
-    unstable_enableSymlinks: true,
+    // unstable_enableSymlinks: true,
     // unstable_enablePackageExports: true,
   },
 };