Skip to content

Commit

Permalink
cleanup(angular): address pr feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
leosvelperez committed May 23, 2024
1 parent c571196 commit 98c83cc
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 6 deletions.
5 changes: 3 additions & 2 deletions docs/generated/packages/angular/generators/setup-ssr.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,9 @@
"appId": {
"type": "string",
"format": "html-selector",
"description": "The `appId` to use with `withServerTransition`. _Note: This is deprecated and ignored since Angular 16 and not supported since Angular 17._",
"default": "serverApp"
"description": "The `appId` to use with `withServerTransition`.",
"default": "serverApp",
"x-deprecated": "This is deprecated and ignored since Angular 16 and not supported since Angular 17."
},
"main": {
"type": "string",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,7 @@ export class StylesheetProcessor {
getInstalledPackageVersionInfo('ng-packagr');
let tailwindConfigPath: string | undefined;
let postcssConfiguration: PostcssConfiguration | undefined;
// TODO(leo): change to a stable version when it's released
if (gte(ngPackagrVersion, '18.0.0-next.3')) {
if (gte(ngPackagrVersion, '18.0.0')) {
const {
findTailwindConfiguration,
generateSearchDirectories,
Expand Down
5 changes: 3 additions & 2 deletions packages/angular/src/generators/setup-ssr/schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,9 @@
"appId": {
"type": "string",
"format": "html-selector",
"description": "The `appId` to use with `withServerTransition`. _Note: This is deprecated and ignored since Angular 16 and not supported since Angular 17._",
"default": "serverApp"
"description": "The `appId` to use with `withServerTransition`.",
"default": "serverApp",
"x-deprecated": "This is deprecated and ignored since Angular 16 and not supported since Angular 17."
},
"main": {
"type": "string",
Expand Down

0 comments on commit 98c83cc

Please sign in to comment.