fix(core): improve local plugin loading by reading only tsconfig comp…

…ile options
nrwl · Nov 27, 2024 · 8a8b3a5 · 8a8b3a5
1 parent b018b94
commit 8a8b3a5
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 15 deletions.
diff --git a/packages/nx/src/plugins/js/utils/register.ts b/packages/nx/src/plugins/js/utils/register.ts
@@ -293,8 +293,7 @@ export function getTranspiler(
  * @returns cleanup method
  */
 export function registerTranspiler(
-  compilerOptions: CompilerOptions,
-  tsConfigRaw?: unknown
+  compilerOptions: CompilerOptions
 ): () => void {
   // Function to register transpiler that returns cleanup function
   const transpiler = getTranspiler(compilerOptions);

diff --git a/packages/nx/src/plugins/js/utils/typescript.ts b/packages/nx/src/plugins/js/utils/typescript.ts
@@ -23,7 +23,7 @@ export function readTsConfig(tsConfigPath: string) {
   );
 }
 
-function readTsConfigOptions(tsConfigPath: string) {
+export function readTsConfigOptions(tsConfigPath: string) {
   if (!tsModule) {
     tsModule = require('typescript');
   }

diff --git a/packages/nx/src/project-graph/plugins/loader.ts b/packages/nx/src/project-graph/plugins/loader.ts
@@ -16,8 +16,8 @@ import {
   registerTsConfigPaths,
 } from '../../plugins/js/utils/register';
 import {
-  ProjectRootMappings,
   findProjectForPath,
+  ProjectRootMappings,
 } from '../utils/find-project-for-path';
 import { normalizePath } from '../../utils/path';
 import { logger } from '../../utils/logger';
@@ -29,8 +29,8 @@ import { PluginConfiguration } from '../../config/nx-json';
 import { retrieveProjectConfigurationsWithoutPluginInference } from '../utils/retrieve-workspace-files';
 import { LoadedNxPlugin } from './internal-api';
 import { LoadPluginError } from '../error-types';
+import { readTsConfigOptions } from '../../plugins/js/utils/typescript';
 import path = require('node:path/posix');
-import { readTsConfig } from '../../plugins/js/utils/typescript';
 
 export function readPluginPackageJson(
   pluginName: string,
@@ -92,19 +92,16 @@ export function registerPluginTSTranspiler() {
     return;
   }
 
-  const tsConfig: Partial<ts.ParsedCommandLine> = tsConfigName
-    ? readTsConfig(tsConfigName)
+  const tsConfigOptions: ts.CompilerOptions = tsConfigName
+    ? readTsConfigOptions(tsConfigName)
     : {};
   const cleanupFns = [
     registerTsConfigPaths(tsConfigName),
-    registerTranspiler(
-      {
-        experimentalDecorators: true,
-        emitDecoratorMetadata: true,
-        ...tsConfig.options,
-      },
-      tsConfig.raw
-    ),
+    registerTranspiler({
+      experimentalDecorators: true,
+      emitDecoratorMetadata: true,
+      ...tsConfigOptions,
+    }),
   ];
   unregisterPluginTSTranspiler = () => {
     cleanupFns.forEach((fn) => fn?.());