Skip to content

Commit

Permalink
feat(angular): update module federation node (#18513)
Browse files Browse the repository at this point in the history
  • Loading branch information
Coly010 authored Aug 18, 2023
1 parent 77bc1e8 commit 8390b9e
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 5 deletions.
3 changes: 1 addition & 2 deletions e2e/angular-core/src/module-federation.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -161,8 +161,7 @@ describe('Angular Module Federation', () => {
await killProcessAndPorts(process.pid, app1Port, app2Port);
}, 20_000_000);

// TODO(colum): enable when this issue is resolved https://github.com/module-federation/universe/issues/604
xit('should scaffold MF + SSR setup successfully', async () => {
it('should scaffold MF + SSR setup successfully', async () => {
const host = uniq('host');
const remote1 = uniq('remote1');
const remote2 = uniq('remote2');
Expand Down
4 changes: 2 additions & 2 deletions packages/angular/src/utils/backward-compatible-versions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export const backwardCompatibleVersions: Record<
typesCorsVersion: '~2.8.5',
expressVersion: '~4.18.2',
typesExpressVersion: '4.17.14',
moduleFederationNodeVersion: '^0.10.1',
moduleFederationNodeVersion: '~1.0.5',
angularEslintVersion: '~14.0.4',
tailwindVersion: '^3.0.2',
postcssVersion: '^8.4.5',
Expand All @@ -52,7 +52,7 @@ export const backwardCompatibleVersions: Record<
typesCorsVersion: '~2.8.5',
expressVersion: '~4.18.2',
typesExpressVersion: '4.17.14',
moduleFederationNodeVersion: '~0.10.1',
moduleFederationNodeVersion: '~1.0.5',
angularEslintVersion: '~15.0.0',
tailwindVersion: '^3.0.2',
postcssVersion: '^8.4.5',
Expand Down
2 changes: 1 addition & 1 deletion packages/angular/src/utils/versions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export const corsVersion = '~2.8.5';
export const typesCorsVersion = '~2.8.5';
export const expressVersion = '~4.18.2';
export const typesExpressVersion = '4.17.14';
export const moduleFederationNodeVersion = '~0.10.1';
export const moduleFederationNodeVersion = '~1.0.5';

export const angularEslintVersion = '~16.0.0';
export const tailwindVersion = '^3.0.2';
Expand Down

1 comment on commit 8390b9e

@vercel
Copy link

@vercel vercel bot commented on 8390b9e Aug 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

nx-dev – ./

nx-dev-git-master-nrwl.vercel.app
nx-five.vercel.app
nx-dev-nrwl.vercel.app
nx.dev

Please sign in to comment.