fix(core): ensure CNW works without .yarnrc with custom registry (#18937

)
nrwl · Oct 18, 2023 · 80ade93 · 80ade93
1 parent aa57429
commit 80ade93
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 1 deletion.
diff --git a/packages/create-nx-workspace/src/utils/package-manager.ts b/packages/create-nx-workspace/src/utils/package-manager.ts
@@ -1,5 +1,5 @@
 import { execSync } from 'child_process';
-import { existsSync, readFileSync, writeFileSync } from 'fs';
+import { existsSync, writeFileSync } from 'fs';
 import { join } from 'path';
 
 /*

diff --git a/packages/devkit/src/tasks/install-packages-task.ts b/packages/devkit/src/tasks/install-packages-task.ts
@@ -42,6 +42,16 @@ export function installPackagesTask(
       cwd: join(tree.root, cwd),
       stdio: process.env.NX_GENERATE_QUIET === 'true' ? 'ignore' : 'inherit',
     };
+    // ensure local registry from process is not interfering with the install
+    // when we start the process from temp folder the local registry would override the custom registry
+    if (
+      process.env.npm_config_registry &&
+      process.env.npm_config_registry.match(
+        /^https:\/\/registry\.(npmjs\.org|yarnpkg\.com)/
+      )
+    ) {
+      delete process.env.npm_config_registry;
+    }
     execSync(pmc.install, execSyncOptions);
   }
 }
diff --git a/packages/nx/src/command-line/migrate/command-object.ts b/packages/nx/src/command-line/migrate/command-object.ts
@@ -111,6 +111,16 @@ function runMigration() {
     if (p === null) {
       runLocalMigrate();
     } else {
+      // ensure local registry from process is not interfering with the install
+      // when we start the process from temp folder the local registry would override the custom registry
+      if (
+        process.env.npm_config_registry &&
+        process.env.npm_config_registry.match(
+          /^https:\/\/registry\.(npmjs\.org|yarnpkg\.com)/
+        )
+      ) {
+        delete process.env.npm_config_registry;
+      }
       execSync(`${p} _migrate ${process.argv.slice(3).join(' ')}`, {
         stdio: ['inherit', 'inherit', 'inherit'],
       });