chore(core): change retrieveProjectConfigurationPaths to async (#18717)

nrwl · Aug 18, 2023 · 7d4e2fe · 7d4e2fe · vercel · Aug 18, 2023
1 parent 97c5ecf
commit 7d4e2fe
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 8 deletions.
diff --git a/packages/nx/src/migrations/update-15-1-0/set-project-names.ts b/packages/nx/src/migrations/update-15-1-0/set-project-names.ts
@@ -7,7 +7,10 @@ import { retrieveProjectConfigurationPaths } from '../../project-graph/utils/ret
 
 export default async function (tree: Tree) {
   const nxJson = readNxJson(tree);
-  const projectFiles = retrieveProjectConfigurationPaths(tree.root, nxJson);
+  const projectFiles = await retrieveProjectConfigurationPaths(
+    tree.root,
+    nxJson
+  );
   const projectJsons = projectFiles.filter((f) => f.endsWith('project.json'));
 
   for (let f of projectJsons) {

diff --git a/packages/nx/src/project-graph/utils/retrieve-workspace-files.spec.ts b/packages/nx/src/project-graph/utils/retrieve-workspace-files.spec.ts
@@ -24,10 +24,10 @@ describe('retrieveProjectConfigurationPaths', () => {
         name: 'project-1',
       })
     );
-    expect(retrieveProjectConfigurationPaths(fs.tempDir, {})).not.toContain(
-      'not-projects/project.json'
-    );
-    expect(retrieveProjectConfigurationPaths(fs.tempDir, {})).toContain(
+    expect(
+      await retrieveProjectConfigurationPaths(fs.tempDir, {})
+    ).not.toContain('not-projects/project.json');
+    expect(await retrieveProjectConfigurationPaths(fs.tempDir, {})).toContain(
       'projects/project.json'
     );
   });

diff --git a/packages/nx/src/project-graph/utils/retrieve-workspace-files.ts b/packages/nx/src/project-graph/utils/retrieve-workspace-files.ts
@@ -182,13 +182,13 @@ function _retrieveProjectConfigurations(
   };
 }
 
-export function retrieveProjectConfigurationPaths(
+export async function retrieveProjectConfigurationPaths(
   root: string,
   nxJson: NxJsonConfiguration
-): string[] {
+): Promise<string[]> {
   const projectGlobPatterns = configurationGlobs(
     root,
-    loadNxPluginsSync(nxJson?.plugins ?? [], getNxRequirePaths(root), root)
+    await loadNxPlugins(nxJson?.plugins ?? [], getNxRequirePaths(root), root)
   );
   const { getProjectConfigurationFiles } =
     require('../../native') as typeof import('../../native');