fix(core): unregister in-process ts transpilers when workspace files …

…are retrieved

package.json

@@ -101,7 +101,7 @@
     "@supabase/supabase-js": "^2.26.0",
     "@svgr/rollup": "^8.0.1",
     "@svgr/webpack": "^8.0.1",
-    "@swc-node/register": "^1.4.2",
+    "@swc-node/register": "~1.6.7",
     "@swc/cli": "0.1.62",
     "@swc/core": "^1.3.51",
     "@swc/jest": "^0.2.20",

packages/js/migrations.json

@@ -98,6 +98,15 @@
           "version": "~5.1.3"
         }
       }
+    },
+    "16.9.0": {
+      "version": "16.9.0-beta.1",
+      "packages": {
+        "@swc/register": {
+          "version": "~1.6.7",
+          "alwaysAddToPackageJson": false
+        }
+      }
     }
   }
 }

packages/js/src/utils/versions.ts

@@ -5,7 +5,7 @@ export const prettierVersion = '^2.6.2';
 export const swcCliVersion = '~0.1.62';
 export const swcCoreVersion = '~1.3.51';
 export const swcHelpersVersion = '~0.5.0';
-export const swcNodeVersion = '~1.4.2';
+export const swcNodeVersion = '~1.6.7';
 export const tsLibVersion = '^2.3.0';
 export const typesNodeVersion = '18.7.1';
 export const verdaccioVersion = '^5.0.4';

packages/nx/package.json

@@ -68,7 +68,7 @@
     "node-machine-id": "1.1.12"
   },
   "peerDependencies": {
-    "@swc-node/register": "^1.4.2",
+    "@swc-node/register": "~1.6.7",
     "@swc/core": "^1.2.173"
   },
   "peerDependenciesMeta": {

packages/nx/src/plugins/js/utils/register.ts

@@ -66,7 +66,9 @@ export function getTsNodeTranspiler(
     warnTsNodeUsage();
   }
 
-  return () => {};
+  return () => {
+    service.enabled(false);
+  };
 }
 
 export function getTranspiler(compilerOptions: CompilerOptions) {

packages/nx/src/project-graph/utils/retrieve-workspace-files.ts

@@ -25,6 +25,7 @@ import {
   loadNxPlugins,
   loadNxPluginsSync,
   NxPluginV2,
+  unregisterPluginTSTranspiler,
 } from '../../utils/nx-plugin';
 import { CreateProjectJsonProjectsPlugin } from '../../plugins/project-json/build-nodes/project-json';
 import {
@@ -84,6 +85,8 @@ export async function retrieveWorkspaceFiles(
     'get-workspace-files:end'
   );
 
+  unregisterPluginTSTranspiler();
+
   return {
     allWorkspaceFiles: buildAllWorkspaceFiles(projectFileMap, globalFiles),
     projectFileMap,

packages/nx/src/utils/nx-plugin.ts

@@ -177,7 +177,7 @@ function getPluginPathAndName(
 
   // Register the ts-transpiler if we are pointing to a
   // plain ts file that's not part of a plugin project
-  if (extension === '.ts' && !tsNodeAndPathsRegistered) {
+  if (extension === '.ts' && !tsNodeAndPathsUnregisterCallback) {
     registerPluginTSTranspiler();
   }
 
@@ -368,14 +368,14 @@ export function resolveLocalNxPlugin(
   return localPluginCache[importPath];
 }
 
-let tsNodeAndPathsRegistered = false;
+let tsNodeAndPathsUnregisterCallback = undefined;
 
 /**
  * Register swc-node or ts-node if they are not currently registered
  * with some default settings which work well for Nx plugins.
  */
 export function registerPluginTSTranspiler() {
-  if (!tsNodeAndPathsRegistered) {
+  if (!tsNodeAndPathsUnregisterCallback) {
     // nx-ignore-next-line
     const ts: typeof import('typescript') = require('typescript');
 
@@ -389,19 +389,33 @@ export function registerPluginTSTranspiler() {
       ? readTsConfig(tsConfigName)
       : {};
 
-    registerTsConfigPaths(tsConfigName);
-    registerTranspiler({
+    const unregisterTsConfigPaths = registerTsConfigPaths(tsConfigName);
+    const unregisterTranspiler = registerTranspiler({
       experimentalDecorators: true,
       emitDecoratorMetadata: true,
       ...tsConfig.options,
       lib: ['es2021'],
       module: ts.ModuleKind.CommonJS,
       target: ts.ScriptTarget.ES2021,
       inlineSourceMap: true,
+      esModuleInterop: true,
       skipLibCheck: true,
     });
+    tsNodeAndPathsUnregisterCallback = () => {
+      unregisterTsConfigPaths();
+      unregisterTranspiler();
+    };
+  }
+}
+
+/**
+ * Unregister the ts-node transpiler if it is registered
+ */
+export function unregisterPluginTSTranspiler() {
+  if (tsNodeAndPathsUnregisterCallback) {
+    tsNodeAndPathsUnregisterCallback();
+    tsNodeAndPathsUnregisterCallback = undefined;
   }
-  tsNodeAndPathsRegistered = true;
 }
 
 function lookupLocalPlugin(importPath: string, root = workspaceRoot) {
@@ -411,7 +425,7 @@ function lookupLocalPlugin(importPath: string, root = workspaceRoot) {
     return null;
   }
 
-  if (!tsNodeAndPathsRegistered) {
+  if (!tsNodeAndPathsUnregisterCallback) {
     registerPluginTSTranspiler();
   }
 
@@ -451,6 +465,7 @@ function findNxProjectForImportPath(
 }
 
 let tsconfigPaths: Record<string, string[]>;
+
 function readTsConfigPaths(root: string = workspaceRoot) {
   if (!tsconfigPaths) {
     const tsconfigPath: string | null = ['tsconfig.base.json', 'tsconfig.json']