fix(bundling): add awaits

nrwl · Nov 27, 2024 · 4d571e8 · 4d571e8
1 parent e0f17c2
commit 4d571e8
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/packages/rspack/src/executors/rspack/lib/config.ts b/packages/rspack/src/executors/rspack/lib/config.ts
@@ -1,4 +1,3 @@
-import { join } from 'path';
 import { ExecutorContext } from '@nx/devkit';
 import { type Configuration } from '@rspack/core';
 import {
@@ -14,7 +13,7 @@ export async function getRspackConfigs(
   options: NormalizedRspackExecutorSchema & { devServer?: any },
   context: ExecutorContext
 ): Promise<Configuration | Configuration[]> {
-  let userDefinedConfig = resolveUserDefinedRspackConfig(
+  let userDefinedConfig = await resolveUserDefinedRspackConfig(
     options.rspackConfig,
     options.tsConfig
   );

diff --git a/packages/rspack/src/plugins/plugin.ts b/packages/rspack/src/plugins/plugin.ts
@@ -124,7 +124,7 @@ async function createRspackTargets(
 ): Promise<RspackTargets> {
   const namedInputs = getNamedInputs(projectRoot, context);
 
-  const rspackConfig = resolveUserDefinedRspackConfig(
+  const rspackConfig = await resolveUserDefinedRspackConfig(
     join(context.workspaceRoot, configFilePath),
     getRootTsConfigPath(),
     true

diff --git a/packages/rspack/src/utils/resolve-user-defined-rspack-config.ts b/packages/rspack/src/utils/resolve-user-defined-rspack-config.ts
@@ -1,7 +1,7 @@
 import { clearRequireCache } from '@nx/devkit/src/utils/config-utils';
 import { registerTsProject } from '@nx/js/src/internal';
 
-export function resolveUserDefinedRspackConfig(
+export async function resolveUserDefinedRspackConfig(
   path: string,
   tsConfig: string,
   /** Skip require cache and return latest content */
@@ -18,7 +18,7 @@ export function resolveUserDefinedRspackConfig(
   // Don't transpile non-TS files. This prevents workspaces libs from being registered via tsconfig-paths.
   // There's an issue here with Nx workspace where loading plugins from source (via tsconfig-paths) can lead to errors.
   if (!/\.(ts|mts|cts)$/.test(path)) {
-    return import(path);
+    return await import(path);
   }
 
   const cleanupTranspiler = registerTsProject(tsConfig);