Skip to content

Commit

Permalink
chore(testing): address flakiness of cypress e2e test when using --po…
Browse files Browse the repository at this point in the history
…rt=cypress-auto (#19712)
  • Loading branch information
jaysoo authored Oct 18, 2023
1 parent 4f13f5a commit 379dff3
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions e2e/cypress/src/cypress.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -158,10 +158,6 @@ describe('env vars', () => {
it(
'should run e2e in parallel',
async () => {
// ensure ports are free before running tests
await killPort(4200);
await killPort(4201);

const ngAppName = uniq('ng-app');
runCLI(
`generate @nx/angular:app ${ngAppName} --e2eTestRunner=cypress --linter=eslint --no-interactive`
Expand All @@ -171,13 +167,7 @@ describe('env vars', () => {
const results = runCLI(
`run-many --target=e2e --parallel=2 --port=cypress-auto --output-style=stream`
);
expect(results).toContain('Using port 4200');
expect(results).toContain('Using port 4201');
expect(results).toContain('Successfully ran target e2e for 2 projects');
checkFilesDoNotExist(
`node_modules/@nx/cypress/src/executors/cypress/4200.txt`,
`node_modules/@nx/cypress/src/executors/cypress/4201.txt`
);
}
},
TEN_MINS_MS
Expand Down

0 comments on commit 379dff3

Please sign in to comment.