fix(misc): isCI should return a boolean

nrwl · Feb 17, 2023 · 2899b3a · 2899b3a · vercel · Feb 17, 2023
1 parent bae35db
commit 2899b3a
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 18 deletions.
diff --git a/packages/create-nx-workspace/bin/output.ts b/packages/create-nx-workspace/bin/output.ts
@@ -10,18 +10,18 @@ export function isCI() {
   return (
     process.env.CI === 'true' ||
     process.env.TF_BUILD === 'true' ||
-    process.env['bamboo.buildKey'] ||
+    process.env.GITHUB_ACTIONS === 'true' ||
     process.env.BUILDKITE === 'true' ||
     process.env.CIRCLECI === 'true' ||
     process.env.CIRRUS_CI === 'true' ||
-    process.env.CODEBUILD_BUILD_ID ||
-    process.env.GITHUB_ACTIONS === 'true' ||
-    process.env.GITLAB_CI ||
-    process.env.HEROKU_TEST_RUN_ID ||
-    process.env.BUILD_ID ||
-    process.env.BUILD_BUILDID ||
-    process.env.TEAMCITY_VERSION ||
-    process.env.TRAVIS === 'true'
+    process.env.TRAVIS === 'true' ||
+    !!process.env['bamboo.buildKey'] ||
+    !!process.env.CODEBUILD_BUILD_ID ||
+    !!process.env.GITLAB_CI ||
+    !!process.env.HEROKU_TEST_RUN_ID ||
+    !!process.env.BUILD_ID ||
+    !!process.env.BUILD_BUILDID ||
+    !!process.env.TEAMCITY_VERSION
   );
 }
 

diff --git a/packages/nx/src/utils/is-ci.ts b/packages/nx/src/utils/is-ci.ts
@@ -2,17 +2,17 @@ export function isCI() {
   return (
     process.env.CI === 'true' ||
     process.env.TF_BUILD === 'true' ||
-    process.env['bamboo.buildKey'] ||
+    process.env.GITHUB_ACTIONS === 'true' ||
     process.env.BUILDKITE === 'true' ||
     process.env.CIRCLECI === 'true' ||
     process.env.CIRRUS_CI === 'true' ||
-    process.env.CODEBUILD_BUILD_ID ||
-    process.env.GITHUB_ACTIONS === 'true' ||
-    process.env.GITLAB_CI ||
-    process.env.HEROKU_TEST_RUN_ID ||
-    process.env.BUILD_ID ||
-    process.env.BUILD_BUILDID ||
-    process.env.TEAMCITY_VERSION ||
-    process.env.TRAVIS === 'true'
+    process.env.TRAVIS === 'true' ||
+    !!process.env['bamboo.buildKey'] ||
+    !!process.env.CODEBUILD_BUILD_ID ||
+    !!process.env.GITLAB_CI ||
+    !!process.env.HEROKU_TEST_RUN_ID ||
+    !!process.env.BUILD_ID ||
+    !!process.env.BUILD_BUILDID ||
+    !!process.env.TEAMCITY_VERSION
   );
 }