fix!: always resolve SHA against provided main branch #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meeroslav
force-pushed
the
add-tests
branch
9 times, most recently
from
0577f5e to
e3eb1d0
Compare
JamesHenry
reviewed
Sep 6, 2022
| fetch-depth: 0 | ||
|
|
||
| - name: Derive appropriate SHAs for base and head for `nx affected` commands | ||
| uses: nrwl/nx-set-shas@v2 |
There was a problem hiding this comment.
Can we reference the action locally instead of by version number here?
There was a problem hiding this comment.
Oh, yes, we should
JamesHenry
reviewed
Sep 6, 2022
README.md
Outdated
| @@ -128,6 +128,7 @@ On a CI system that runs on submitted PRs, we determine what commits to include | |||
|
|
|||
| But what if we want to set up a continuous deployment system | |||
| that, as changes get pushed to `master`, builds and deploys | |||
| only the affected projects? | |||
There was a problem hiding this comment.
What's up with the newlines within this paragraph? :)
There was a problem hiding this comment.
That got lost on another commit. I have fixed it on main and rebased to this PR
JamesHenry
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes first set of tests.
Includes #52 necessary for checks on push.
This results in unfortunate breaking changes for some folks (#57 (comment))
The test set should be expanded later to ensure we check different scenarios.
This is to be investigated as it might need to include a controlled git sub repo.
Related to #62
BREAKING CHANGE