Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: GH Actions use read for actions permission #54

Merged
merged 1 commit into from
Sep 1, 2022
Merged

docs: GH Actions use read for actions permission #54

merged 1 commit into from
Sep 1, 2022

Conversation

spg
Copy link
Contributor

@spg spg commented Aug 24, 2022

write is not necessary

LayZeeDK
LayZeeDK suggested changes Aug 31, 2022
View reviewed changes
Copy link
Contributor

@LayZeeDK LayZeeDK left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the GitHub API requests and there are only GET requests, so no actions write permissions needed.

@meeroslav
Copy link
Collaborator

Thank you @spg for the PR and thank you @LayZeeDK for the review.

@meeroslav meeroslav changed the title GH Actions: use read for actions permission docs: GH Actions use read for actions permission Sep 1, 2022
@meeroslav meeroslav merged commit 837dc32 into nrwl:main Sep 1, 2022
@spg spg deleted the patch-1 branch September 1, 2022 09:28
LayZeeDK pushed a commit to LayZeeDK/nrwl-nx-set-shas that referenced this pull request Sep 1, 2022
@spg @LayZeeDK
docs(README): use read only for actions permission (nrwl#54)
7a454d0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LayZeeDK LayZeeDK LayZeeDK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spg @meeroslav @LayZeeDK