Handle multiple types for advanced scenarios #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sparr
reviewed
May 21, 2024
Comment on lines
+170
to
+187
| if (lastSuccessfulEvent.includes(",")) { | ||
| // find the greatest workflow id among the types and retrieve the sha | ||
| const events = lastSuccessfulEvent.split(","); | ||
| const workflowIdMap = new Map(); | ||
| for (const event of events) { |
There was a problem hiding this comment.
This if condition and the else code path below seems unnecessary. A string with no commas, e.g. "foo", will split(",") to ["foo"] and the iteration will work fine over that single element.
sparr
reviewed
May 21, 2024
| }); | ||
| workflowIdMap.set(workflowRun.id, workflowRun.head_sha); | ||
| } | ||
| shas.push(workflowIdMap.get(Math.max(...workflowIdMap.keys()))); |
There was a problem hiding this comment.
This seems like it will push all the SHAs from one event, then all of them from another. So they won't be in order in the final array. Which means the call to findExistingCommit below, which returns the first commit in the list that exists, might not return the correct commit?
mandarini
force-pushed
the
feature/142-leverage-multiple-event-types
branch
from
6888a24 to
ab3c552
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.