Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix commitExists() function for diff bigger than 30 commits #136

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

korniychuk
Copy link
Contributor

When the diff between NX_BASE & NX_HEAD is bigger than 30 commits the commitExests returns false, because it checks only last 30 commits inside the target branch. It happens because GET /repos/{owner}/{repo}/commits has default per_page value of 30.

In our workflow, a few times a week we have the diff ~50 commits since the last successful run. As the result nrwl/nx-set-shas can't find NX_BASE correct and returns HEAD~1.

Issue screenshot

image

@korniychuk korniychuk force-pushed the fix-broken-commits-search branch from ea88a0c to 008e789 Compare December 14, 2023 11:55
@korniychuk
Copy link
Contributor Author

Hi @JamesHenry 🙌 Please, help with it :)

@JamesHenry JamesHenry merged commit 76907e7 into nrwl:main Dec 14, 2023
6 checks passed
@JamesHenry
Copy link
Collaborator

Thanks @korniychuk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants