Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where does fallbackSHA come from (or is it missing?) #158

Open
joh-klein opened this issue Jun 11, 2024 · 10 comments
Open

Where does fallbackSHA come from (or is it missing?) #158

joh-klein opened this issue Jun 11, 2024 · 10 comments
Assignees

Comments

@joh-klein
Copy link

You have fallbackSHA here but it isn't added as one of the list of arguments here – did you maybe forget to add it, or am I blind and don't see it? :)

@joh-klein
Copy link
Author

Would it maybe make things easier, if it was a "JS Action"? Then we could use core.getInput(). I can start a PR for that, if you want.

@mandarini
Copy link
Member

Hi @joh-klein ! Yes, can you please make a PR? Thank you for your patience!

@joh-klein
Copy link
Author

Hi, @mandarini OK, I'll try - could you maybe merge some of the PRs? Otherwise it will be very hard to merge them after this somewhat bigger change

@mandarini
Copy link
Member

Done! :D

joh-klein added a commit to joh-klein/nx-set-shas that referenced this issue Jun 26, 2024
@dougludlow
Copy link

Just ran in to this today. Dug into the code after fighting with it for a couple hours... The option is being ignored and not being passed into the script.

@joh-klein
Copy link
Author

Yeah. I addressed this in the promised PR …

@kumboleijo
Copy link
Contributor

Any plan on fixing this before migrating to JS action?

@joh-klein
Copy link
Author

I have no idea why there is so much radio silence about my PR – @mandarini is there anything I can do to move it along?

@mandarini
Copy link
Member

Hi @joh-klein , I am really sorry I was out of office for quite some time due to some personal issues and this got lost. I'll make sure I review this by the end of the week. I understand your frustration and I appreciate your patience.

@joh-klein
Copy link
Author

Thank you so much for your response. I truly appreciate your honesty and the effort you're putting into this despite the challenges you've been facing. Please don't worry about the delay—your personal well-being comes first. Take your time, and I'm looking forward to hearing from you whenever you're ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants