Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(set-shas): fixing incorrect api page-token query param #44

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

eladhaim22
Copy link
Contributor

Change page query param to page-token query param
Closes #43

Change page query param to page-token query param
Closes nrwl#43
@pedroyan
Copy link

pedroyan commented Oct 5, 2022

Hi @meeroslav!

Not sure if you were notified of this PR, but could you take a look at this when you get the chance? We are currently experiencing issues with our Prod Nx-based pipelines due to this bug :(

(Exact problem described here #42)

Copy link
Collaborator

@meeroslav meeroslav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@meeroslav meeroslav self-assigned this Oct 14, 2022
@meeroslav meeroslav merged commit a59c311 into nrwl:main Oct 14, 2022
@meeroslav meeroslav changed the title patch: fixing api - page-token query string fix(set-shas): fixing incorrect api page-token query param Oct 14, 2022
@vsavkin
Copy link
Member

vsavkin commented Oct 14, 2022

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/nrwl/nx?version=dev:a59c3116a663e9bf3107e03df727049e4eb61a95

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong query string parameter call results in same page of pipelines
5 participants