Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support yarn v2+ #24

Closed
Wykks opened this issue Aug 6, 2022 · 6 comments · Fixed by #43
Closed

Support yarn v2+ #24

Wykks opened this issue Aug 6, 2022 · 6 comments · Fixed by #43
Assignees
Labels
enhancement New feature or request

Comments

@Wykks
Copy link

Wykks commented Aug 6, 2022

I noticed a cache issue with yarn v2+:

- name: Get yarn cache directory path
if: steps.package_manager.outputs.name == 'yarn'
id: yarn-cache-dir-path
run: echo "::set-output name=dir::$(yarn cache dir)"

yarn cache dir doesn't exist in yarn 2+

This should be done instead:

https://github.com/actions/cache/blob/main/examples.md#node---yarn-2

Edit: also --immutable should be used instead of --frozen-lockfile at the install step

@meeroslav
Copy link
Collaborator

Nx at the moment does not support fully yarn berry, so even if you would fix this there's a chance your install would not work.

Hopefully, we will have the support soon.

@Wykks
Copy link
Author

Wykks commented Aug 9, 2022

It's actually working: https://github.com/Wykks/ngx-mapbox-gl/actions/runs/2810203839
Just not using the cache.

I'm aware that nx doesn't support yarn berry fully because of pnp mode.
But with the "nodeLinker: node-modules" mode, I don't see any reason to prefer yarn v1 instead of yarn berry.

Welp, I can live with no cache :)

@meeroslav meeroslav self-assigned this Aug 10, 2022
@meeroslav meeroslav added enhancement New feature or request and removed blocked labels Nov 3, 2022
@Michsior14
Copy link
Contributor

The current version of yarn berry (3.2.4) and cache check doesn't work anymore:
https://github.com/Michsior14/ngrx-addons/actions/runs/3436100975/jobs/5729233284

@meeroslav
Copy link
Collaborator

meeroslav commented Nov 10, 2022

@Michsior14 cache check never worked, check #24 (comment)

That's why the issue is still open. Hopefully we'll get to it soon

@Michsior14
Copy link
Contributor

@meeroslav Yep I know, what I meant is that it was working fine (without the cache) in the past, but since v3.2.4 the pipelines fails due to the wrong command in the cache check. Sorry for confusion ;)

@meeroslav
Copy link
Collaborator

Oh, ok, we'll have a look at it as soon as possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants