Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSPS object is not rendered properly #181

Closed
yigitsoy opened this issue Mar 8, 2021 · 6 comments
Closed

GSPS object is not rendered properly #181

yigitsoy opened this issue Mar 8, 2021 · 6 comments

Comments

@yigitsoy
Copy link

yigitsoy commented Mar 8, 2021

First of all, thank for providing this great tool for the usage of the community.

Describe the bug
I am trying to display a GSPS object that I created together with the original CT DICOM series. The GSPS object contains a binary segmentation (a rough brain extraction for example purposes) which I added to the Overlay Plane as bitmap.

To Reproduce
Steps to reproduce the behavior:

  1. Load the CT series CT2 from 77654033_19950903.tar.bz2
  2. Load the corresponding set of GSPS objects in the attachment 77654033_gsps.zip
  3. Select YUNA_GSPS from the "Presentation State" menu (in the view area on the right)
  4. The overlay is not visible.

Expected behavior
The overlay bitmap is shown on top of the original image.

Desktop (please complete the following information):

***** Configuration *****
  Last running version = 3.7.0
  Current version = 3.7.0
  Application name = Weasis
  Application Source ID = 419B40DE
  Application Profile = default
  Application local codebase = /Applications/Weasis.app/Contents/app
  Application codebase URL = file:/Applications/Weasis.app/Contents/app
  Application configuration file = file:/Applications/Weasis.app/Contents/app/conf/config.properties
  Application extension configuration file = file:/Applications/Weasis.app/Contents/app/conf/ext-config.properties
  User = mehmet
  User home directory = /Users/mehmet/.weasis
  Resources path = /Applications/Weasis.app/Contents/app/resources
  Preferences directory = /Users/mehmet/.weasis/preferences/mehmet/default
  Look and Feel = com.apple.laf.AquaLookAndFeel
  Languages path = file:/Applications/Weasis.app/Contents/app/bundle-i18n/
  Languages available = en,ar,bs_BA,bg_BG,zh,zh_CN,zh_TW,hr_HR,cs,fr,de,el,hu_HU,it,ja,ko,ms_MY,pl_PL,pt,pt_BR,ro,ru_RU,sr_RS,sk_SK,es,sv,tr,uk,vi,vi_VN
  OSGI native specs = macosx-x86-64
  HTTP user agent = Weasis/3.7.0 (Mac OS X; 10.16; x86_64; default; NATIVE)
  Operating system = Mac OS X 10.16 x86_64
  Java vendor = Oracle Corporation
  Java version = 16

  Java Path = /Applications/Weasis.app/Contents/runtime/Contents/Home
  Java max memory (less survivor space) = 2.0 GiB
***** End of Configuration *****

Screenshots
image

Traces
If applicable, add log files from Weasis, Java Runtime or PACS.

@nroduit
Copy link
Owner

nroduit commented Mar 9, 2021

I publish a fix for this regression.

However, I think we should add an option to display overlays in transparency of a color or transform to 2D graphics. There is the same problem to display DICOM SEG (which should be supported in the next version). The latter would be more appropriate in this case than DICOM PR.

@yigitsoy
Copy link
Author

yigitsoy commented Mar 9, 2021

Thanks for the quick fix. I think it is possible to set a preferred color via GraphicLayerRecommendedDisplayCIELabValue which can be used as the color for the entire GraphicLayer. I am not sure about the transparency though.

Is there going to be a release soon or is there a nightly build that I can test?

@yigitsoy
Copy link
Author

yigitsoy commented Mar 9, 2021

Btw, I noticed that the GraphicLayerSequence was not set correctly in the GSPS objects I shared earlier. I attached the latest versions here.

@nroduit
Copy link
Owner

nroduit commented Mar 9, 2021

I just run a build here

@yigitsoy
Copy link
Author

yigitsoy commented Mar 9, 2021

Perfect. I can verify that overlay is displayed correctly now. Thanks for your quick support.

I haven't tested with GraphicLayerRecommendedDisplayCIELabValue yet with but having the possibility to assign/change colors/transparency of overlay or an entire GraphicLayer in the GUI would be perfect in the future.

@nroduit
Copy link
Owner

nroduit commented Mar 14, 2021

Close this issue and open a feature request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants