-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Scala 2.12.0 #58
Comments
Yeah, I realised that this weekend. I need to look into this though, as there are a few potential roadblocks:
Thoughts on the matter are quite welcome. |
You also have a ScalaTest dependency but it should already be published. 2.12 artifacts will have to be Java 8 only, whereas 2.11 (or below) will support Java 7 and above as they should now. Does this answer your roadblocks? |
Oh no I know sbt supports cross building - kantan.csv already has published artifacts for 2.11.8 and 2.10.6. What I'm not sure it supports is something like: 2.12.0 -> java 8, 2.11.8 -> java 7, ... I'll look into it. Regarding scalaz-stream / fs2: you're entirely right, and there's already a ticket (#51) for that. Last time I looked, it meant dropping support for 2.10, which makes me a bit uncomfortable - kantan.csv doesn't have many users, but a significant part of them are running 2.10 (because of spark, mostly). There are also some "hidden" dependencies - kantan.codecs has a lot of transitive dependencies, including scalaz, cats, shapeless... libraries that I'm pretty sure will get a 2.12.0 release fairly soon, but don't have one yet. But yeah, the ones you created tickets for were the ones I was worried about. I'm not 100% sure they're still actively maintained. Not necessarily a show stopper, it'll just mean I need to drop them from the benchmarks, but since scala-csv is the main kantan.csv alternative, it'd be a shame. Thanks a lot for creating these tickets by the way, they probably carry more weight from a user than from a competing library author :) |
Ok, so my worries about needing to drop java 7 support are entirely unfounded. It'll actually require simplifying my build process: nrinaudo/kantan.sbt#6 . |
FS2 unblocked. Updating issue with strikethrough. typelevel/fs2#757 (comment) |
scala-csv unblocked: tototoshi/scala-csv#93 |
I think most dependencies are good now, except for This is going to have to wait on #59 though, which I'm struggling with right now. Feel free to check what's getting me stuck and lending a hand :) |
product-collections unblocked: So we're now only blocked on #59 ;) |
Actually, one more: non/imp#11. |
Also, I think scala-csv artifacts are not yet published. Only a matter of time until they are, but I can't seem to find them. |
Regarding scalaz-stream / fs2: turns out supporting fs2 actually means dropping support for 2.10. On the other hand, scalaz-stream now has a 2.12 build. |
Then no need to migrate yet, which is good. |
Almost there, I think. Still blocked on typelevel/cats#1450, but once that's done it looks pretty straightforward, provided 2.12 doesn't break too many things. |
Update on this: all dependencies are now available. I need to work out a couple of behavioural changes in implicit resolutions to get tests to compile again, but so far, all tests that compile pass. Shouldn't be much longer. |
There appears to be some weird issues with unidoc that I still need to track down.
0.1.16-SNAPSHOT has been published with artifacts for Scala 2.12.0. Don't forget to declare the proper snapshot repository if you want to play with this: resolvers := Seq(Resolver.sonatypeRepo("snapshots")) |
Seems to be secretly out.
The text was updated successfully, but these errors were encountered: