Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nrfx 6553 fix tls handling for s2ram #2129

Merged

Conversation

adamkondraciuk
Copy link
Contributor

@adamkondraciuk adamkondraciuk commented Oct 17, 2024

The S2RAM procedure requires marker checking after reset. Such checking is performed on very early stage of the system initialization and must ensure that the stack is not used due to the TLS pointer which is not initialized yet.

Copy link
Contributor

@nordic-piks nordic-piks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basic testing fine.

@adamkondraciuk adamkondraciuk force-pushed the NRFX-6553-Fix-TLS-handling-for-s2ram branch 6 times, most recently from 0fce6d7 to cbd25e1 Compare October 24, 2024 13:23
@adamkondraciuk adamkondraciuk force-pushed the NRFX-6553-Fix-TLS-handling-for-s2ram branch 8 times, most recently from 7aa0809 to 3e3e15c Compare November 4, 2024 08:10
@adamkondraciuk adamkondraciuk force-pushed the NRFX-6553-Fix-TLS-handling-for-s2ram branch from 3e3e15c to 4ee9e91 Compare November 4, 2024 12:44
@adamkondraciuk adamkondraciuk added this to the ncs-2.8.0 milestone Nov 4, 2024
@adamkondraciuk adamkondraciuk force-pushed the NRFX-6553-Fix-TLS-handling-for-s2ram branch from 4ee9e91 to d6814e3 Compare November 4, 2024 17:53
…ions

The S2RAM procedure requires marker checking after reset.
Such checking is performed on very early stage of the system initialization
and must ensure that the stack is not used due to the TLS pointer which is
not initialized yet.

Signed-off-by: Adam Kondraciuk <[email protected]>
(cherry picked from commit 474d4c3)
Rework Nordic specific S2RAM marking procedures.
The S2RAM marking procedures must not disrupt the stack due to
the TLS pointer not yet being initialized during their execution.

Signed-off-by: Adam Kondraciuk <[email protected]>
(cherry picked from commit 59629d0)
@adamkondraciuk adamkondraciuk force-pushed the NRFX-6553-Fix-TLS-handling-for-s2ram branch from d6814e3 to 84b1131 Compare November 5, 2024 08:14
@adamkondraciuk adamkondraciuk added the backport v3.7.99-ncs1-branch Relates to NCS v2.8-branch label Nov 5, 2024
@rlubos rlubos merged commit b16abc6 into nrfconnect:main Nov 5, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants