-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nrfx 6553 fix tls handling for s2ram #2129
Merged
rlubos
merged 2 commits into
nrfconnect:main
from
adamkondraciuk:NRFX-6553-Fix-TLS-handling-for-s2ram
Nov 5, 2024
Merged
Nrfx 6553 fix tls handling for s2ram #2129
rlubos
merged 2 commits into
nrfconnect:main
from
adamkondraciuk:NRFX-6553-Fix-TLS-handling-for-s2ram
Nov 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NordicBuilder
requested review from
anangl,
jaz1-nordic,
kl-cruz,
magp-nordic,
masz-nordic,
nika-nordic and
stephanosio
October 17, 2024 11:33
adamkondraciuk
requested review from
nordic-piks and
karstenkoenig
and removed request for
kl-cruz,
stephanosio,
anangl,
nika-nordic,
masz-nordic,
magp-nordic and
jaz1-nordic
October 17, 2024 11:33
adamkondraciuk
force-pushed
the
NRFX-6553-Fix-TLS-handling-for-s2ram
branch
from
October 18, 2024 08:50
a3238ca
to
19a78cd
Compare
NordicBuilder
requested review from
anangl,
jaz1-nordic,
kl-cruz,
magp-nordic and
masz-nordic
October 18, 2024 08:50
nordic-piks
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basic testing fine.
adamkondraciuk
force-pushed
the
NRFX-6553-Fix-TLS-handling-for-s2ram
branch
6 times, most recently
from
October 24, 2024 13:23
0fce6d7
to
cbd25e1
Compare
nordic-krch
approved these changes
Oct 24, 2024
hubertmis
approved these changes
Oct 24, 2024
adamkondraciuk
force-pushed
the
NRFX-6553-Fix-TLS-handling-for-s2ram
branch
8 times, most recently
from
November 4, 2024 08:10
7aa0809
to
3e3e15c
Compare
adamkondraciuk
force-pushed
the
NRFX-6553-Fix-TLS-handling-for-s2ram
branch
from
November 4, 2024 12:44
3e3e15c
to
4ee9e91
Compare
adamkondraciuk
force-pushed
the
NRFX-6553-Fix-TLS-handling-for-s2ram
branch
from
November 4, 2024 17:53
4ee9e91
to
d6814e3
Compare
…ions The S2RAM procedure requires marker checking after reset. Such checking is performed on very early stage of the system initialization and must ensure that the stack is not used due to the TLS pointer which is not initialized yet. Signed-off-by: Adam Kondraciuk <[email protected]> (cherry picked from commit 474d4c3)
Rework Nordic specific S2RAM marking procedures. The S2RAM marking procedures must not disrupt the stack due to the TLS pointer not yet being initialized during their execution. Signed-off-by: Adam Kondraciuk <[email protected]> (cherry picked from commit 59629d0)
adamkondraciuk
force-pushed
the
NRFX-6553-Fix-TLS-handling-for-s2ram
branch
from
November 5, 2024 08:14
d6814e3
to
84b1131
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The S2RAM procedure requires marker checking after reset. Such checking is performed on very early stage of the system initialization and must ensure that the stack is not used due to the TLS pointer which is not initialized yet.