[nrf noup] modules: mbedtls: Remove Nordic only PSA wants #2077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomi-font
approved these changes
Oct 8, 2024
tejlmand
requested changes
Oct 8, 2024
There was a problem hiding this comment.
we should not be creating noup patches for things that can line in downstream repos.
Why is this being moved to a noup patch ?
it will just make future upmerges harder to handle of this principle spreads.
This is why we try to make Zephyr modular so downstream stuff can stay in the downstream repos.
Vge0rge
force-pushed
the
move_psa_wants
branch
from
a5de972 to
71d38c5
Compare
Vge0rge
changed the title
What you say make sense to me @tejlmand , so I just reverted the noup here and I moved the file in nrf_security. |
frkv
approved these changes
Oct 15, 2024
Vge0rge
force-pushed
the
move_psa_wants
branch
3 times, most recently
from
5a7e66e to
24be01b
Compare
tejlmand
approved these changes
Oct 18, 2024
Vge0rge
force-pushed
the
move_psa_wants
branch
2 times, most recently
from
cd1c4b7 to
2f7a07d
Compare
Revert this noup sicne these configurations are now moved to sdk-nrf to reduce the amount of noups in Zephyr. This reverts commit 0892bad. Signed-off-by: Georgios Vasilakis <[email protected]>
Vge0rge
force-pushed
the
move_psa_wants
branch
from
2f7a07d to
885320a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove Nordic only PSA want Kconfigs fro Zephyr to nrf_security.