Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nrf fromtree] tests: drivers: flash: common: Increase test coverage #1881

Closed

Conversation

nordic-segl
Copy link
Contributor

@nordic-segl nordic-segl commented Jul 10, 2024

Add functional test for flash_erase().
Add negative tests for flash_read(), flas_write(), flash_erase(), flash_fill() and flash_flatten().
Add functional test for flash page layout.

manifest-pr-skip

@nordic-segl nordic-segl force-pushed the NRFX-6031_Test-FLASH-erase branch from 03e169b to ffeced2 Compare July 10, 2024 08:44
nordic-segl added a commit to nordic-segl/sdk-nrf that referenced this pull request Jul 10, 2024
tests: drivers: flash: common: Add explicit test for flash_erase
nrfconnect/sdk-zephyr#1881
zephyrproject-rtos/zephyr#75360

Signed-off-by: Sebastian Głąb <[email protected]>
@nordic-segl
Copy link
Contributor Author

nordic-segl commented Jul 10, 2024

Latest version of the Flash driver needs to be pulled in from upstream.

I get following build error for nrf54H20:
../../src/main.c:264:14: warning: implicit declaration of function 'flash_fill' [-Wimplicit-function-declaration]
../../src/main.c:293:14: warning: implicit declaration of function 'flash_flatten'; did you mean 'flash_erase'? [-Wimplicit-function-declaration]

I get following build error for nrf54L15:
/home/segl/workspace/ncs/nrf/include/flash_map_pm.h:52:18: error: 'PM_PM_PM_storage_partition_ID_LABEL_OFFSET' undeclared (first use in this function)

@nordic-segl nordic-segl force-pushed the NRFX-6031_Test-FLASH-erase branch from ffeced2 to ff91e4e Compare July 11, 2024 05:32
nordic-segl added a commit to nordic-segl/sdk-nrf that referenced this pull request Jul 11, 2024
tests: drivers: flash: common: Add explicit test for flash_erase
nrfconnect/sdk-zephyr#1881
zephyrproject-rtos/zephyr#75360

Signed-off-by: Sebastian Głąb <[email protected]>
@nordic-segl nordic-segl force-pushed the NRFX-6031_Test-FLASH-erase branch from ff91e4e to 51151dd Compare August 19, 2024 06:37
nordic-segl added a commit to nordic-segl/sdk-nrf that referenced this pull request Aug 19, 2024
tests: drivers: flash: common: Add explicit test for flash_erase
nrfconnect/sdk-zephyr#1881
zephyrproject-rtos/zephyr#75360

Signed-off-by: Sebastian Głąb <[email protected]>
@nordic-segl nordic-segl force-pushed the NRFX-6031_Test-FLASH-erase branch 2 times, most recently from 8b7d2a2 to 77c67f0 Compare August 20, 2024 08:42
@nordic-segl nordic-segl changed the title [nrf fromlist] tests: drivers: flash: common: Increase test coverage [nrf fromtree] tests: drivers: flash: common: Increase test coverage Aug 20, 2024
@nordic-segl nordic-segl force-pushed the NRFX-6031_Test-FLASH-erase branch 2 times, most recently from ea30363 to e5d417e Compare August 27, 2024 10:42
nordic-segl added a commit to nordic-segl/sdk-nrf that referenced this pull request Aug 27, 2024
tests: drivers: flash: common: Add explicit test for flash_erase
nrfconnect/sdk-zephyr#1881
zephyrproject-rtos/zephyr#75360

Signed-off-by: Sebastian Głąb <[email protected]>
@nordic-segl nordic-segl force-pushed the NRFX-6031_Test-FLASH-erase branch from e5d417e to 6ad5d8d Compare September 9, 2024 05:42
nordic-segl added a commit to nordic-segl/sdk-nrf that referenced this pull request Sep 9, 2024
tests: drivers: flash: common: Add explicit test for flash_erase
nrfconnect/sdk-zephyr#1881
zephyrproject-rtos/zephyr#75360

Signed-off-by: Sebastian Głąb <[email protected]>
Add functional test for flash_erase().
Add negative tests for flash_read(), flas_write(), flash_erase(),
flash_fill() and flash_flatten().
Add functional test for flash page layout.

Signed-off-by: Sebastian Głąb <[email protected]>
(cherry picked from commit 1a48a01)
…te project

Move negative tests for flash driver to a separate test suite.
Run negative tests only on platforms that are aligned.

Signed-off-by: Sebastian Głąb <[email protected]>
(cherry picked from commit ffd065f)
@nordic-segl nordic-segl force-pushed the NRFX-6031_Test-FLASH-erase branch from 6ad5d8d to 5b67768 Compare September 16, 2024 06:36
nordic-segl added a commit to nordic-segl/sdk-nrf that referenced this pull request Sep 16, 2024
tests: drivers: flash: common: Add explicit test for flash_erase
nrfconnect/sdk-zephyr#1881
zephyrproject-rtos/zephyr#75360

Signed-off-by: Sebastian Głąb <[email protected]>
@nordic-segl
Copy link
Contributor Author

Upmerge has bring in these changes.

@nordic-segl nordic-segl closed this Oct 7, 2024
@nordic-segl nordic-segl deleted the NRFX-6031_Test-FLASH-erase branch October 7, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants