Skip to content

Upmerge 2024.12.20 #8417

Upmerge 2024.12.20

Upmerge 2024.12.20 #8417

Triggered via pull request January 17, 2025 15:34
Status Failure
Total duration 29m 33s
Artifacts 1

compliance.yml

on: pull_request
Run compliance checks on patch series (PR)
29m 16s
Run compliance checks on patch series (PR)
Fit to window
Zoom out
Zoom in

Annotations

19 errors and 5 warnings
Run compliance checks on patch series (PR): BinaryFiles.txt#L1
No binary files allowed. Binary file not allowed: samples/net/sockets/http_server/src/certs/ca.der Binary file not allowed: samples/net/sockets/http_server/src/certs/ca_cert.der Binary file not allowed: samples/net/sockets/http_server/src/certs/server_cert.der Binary file not allowed: samples/net/sockets/http_server/src/certs/server_privkey.der
Run compliance checks on patch series (PR): Checkpatch.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#coding-style for more details. -:9888: WARNING:BRACES: braces {} are required around if/while/for/else #9888: FILE: arch/xtensa/core/elf.c:48: + if (ext->sect_hdrs[sh_ndx].sh_addr <= *got_entry && + *got_entry < -:119462: WARNING:BRACES: braces {} are required around if/while/for/else #119462: FILE: drivers/clock_control/clock_control_npcm.c:346: + while (sys_test_bit(priv->hfcgctrl, NPCM_HFCGCTRL_CLK_CHNG)) + ; -:123357: WARNING:BRACES: braces {} are required around if/while/for/else #123357: FILE: drivers/counter/counter_renesas_ra_agt.c:76: + while (!(reg->AGTCR & BIT(R_AGTX0_AGT16_CTRL_AGTCR_TCSTF_Pos)) && likely(--timeout)) + ; -:123370: WARNING:BRACES: braces {} are required around if/while/for/else #123370: FILE: drivers/counter/counter_renesas_ra_agt.c:89: + while ((reg->AGTCR & BIT(R_AGTX0_AGT16_CTRL_AGTCR_TCSTF_Pos)) && likely(--timeout)) + ; -:131178: WARNING:BRACES: braces {} are required around if/while/for/else #131178: FILE: drivers/dma/dma_mcux_edma.c:640: + if (pre_idx >= CONFIG_DMA_TCD_QUEUE_SIZE) + pre_idx = CONFIG_DMA_TCD_QUEUE_SIZE - 1; -:132117: WARNING:BRACES: braces {} are required around if/while/for/else #132117: FILE: drivers/dma/dma_nxp_sdma.c:79: + if (bytes > chan_data->stat.pending_length) + return -EINVAL; -:132123: WARNING:BRACES: braces {} must be used on all arms of this statement #132123: FILE: drivers/dma/dma_nxp_sdma.c:85: + if (chan_data->stat.read_position > chan_data->stat.write_position) [...] + else [...] -:132137: WARNING:BRACES: braces {} are required around if/while/for/else #132137: FILE: drivers/dma/dma_nxp_sdma.c:99: + if (bytes > chan_data->stat.free) + return -EINVAL; -:132143: WARNING:BRACES: braces {} must be used on all arms of this statement #132143: FILE: drivers/dma/dma_nxp_sdma.c:105: + if (chan_data->stat.write_position > chan_data->stat.read_position) [...] + else [...] -:132175: WARNING:BRACES: braces {} are required around if/while/for/else #132175: FILE: drivers/dma/dma_nxp_sdma.c:137: + if (chan_data->cb) + chan_data->cb(chan_data->dev, chan_data->arg, i, DMA_STATUS_BLOCK); -:132419: WARNING:BRACES: braces {} are required around if/while/for/else #132419: FILE: drivers/dma/dma_nxp_sdma.c:381: + if (!size) + return 0; -:132422: WARNING:BRACES: braces {} must be used on all arms of this statement #132422: FILE: drivers/dma/dma_nxp_sdma.c:384: + if (chan_data->direction == MEMORY_TO_PERIPHERAL) [...] + else [...] -:132454: WARNING:BRACES: braces {} are required around if/while/for/else #132454: FILE: drivers/dma/dma_nxp_sdma.c:416: + if (chan_id == 0) + return false; -:132457: WARNING:BRACES: braces {} are required around if/while/for/else #132457: FILE: drivers/dma/dma_nxp_sdma.c:419: + if (chan_id >= FSL_FEATURE_SDMA_MODULE_CHANNEL) + return false; -:146199: WARNING:BRACES: braces {} are required around if/while/for/else #146199: FILE: drivers/flash/flash_stm32h7x.c:267: + while ((FLASH_STM32_REGS(dev)->SR1 & FLASH_SR_QW) || + (FLASH_STM32_REGS(dev)->SR2 & FLASH_SR_QW)) #else while (FLASH_STM32_REGS(dev)->SR1 & FLASH_SR_QW) #endif -:153152: WARNING:BRACES: braces {} are required around if/while/for/else #153152: FILE: drivers/gpio/gpio_max149x6.h:16: + if ((bit1) & (bit2)) \ + LOG_ERR("[%s] %d", #bit1, bit1) +#define PRINT_ERR(bit) \ + if (bit) \ + LOG_ERR("[DIAG] [%s] %d\n", #bit, bit) +#define PRINT_INF(bit) LOG_INFO("[%s] %d\n", #bit, bit) -:153155: WARNING:BRACES: braces {} are required around if/while/for/else #153155: FILE: drivers/gpio/gpio_max149x6.h:19: + if (bit) \ + LOG_ERR("[DIAG] [%s] %d\n", #bit, bit) +#define PRINT_INF(bit) LOG_INFO("[%s] %d\n", #bit, bit) +#define LOG_DIAG(...) Z_LOG(LOG_LEVEL_ERR, __VA_ARGS__) -
Run compliance checks on patch series (PR): GitDiffCheck.txt#L1
Git conflict markers and whitespace errors are not allowed in added changes 5ca1ed29589fda348a49a7e70b593e1ec0add7a9: tests/bluetooth/qualification/ICS_Zephyr_Bluetooth_Host.bqw:2: trailing whitespace. 5ca1ed29589fda348a49a7e70b593e1ec0add7a9: tests/bluetooth/qualification/ICS_Zephyr_Bluetooth_Host.bqw:5: trailing whitespace. 5ca1ed29589fda348a49a7e70b593e1ec0add7a9: tests/bluetooth/qualification/ICS_Zephyr_Bluetooth_Host.bqw:10: trailing whitespace. 5ca1ed29589fda348a49a7e70b593e1ec0add7a9: tests/bluetooth/qualification/ICS_Zephyr_Bluetooth_Host.bqw:11: trailing whitespace. 5ca1ed29589fda348a49a7e70b593e1ec0add7a9: tests/bluetooth/qualification/ICS_Zephyr_Bluetooth_Host.bqw:12: trailing whitespace. 5ca1ed29589fda348a49a7e70b593e1ec0add7a9: tests/bluetooth/qualification/ICS_Zephyr_Bluetooth_Host.bqw:13: trailing whitespace. 5ca1ed29589fda348a49a7e70b593e1ec0add7a9: tests/bluetooth/qualification/ICS_Zephyr_Bluetooth_Host.bqw:14: trailing whitespace. 5ca1ed29589fda348a49a7e70b593e1ec0add7a9: tests/bluetooth/qualification/ICS_Zephyr_Bluetooth_Host.bqw:15: trailing whitespace. 5ca1ed29589fda348a49a7e70b593e1ec0add7a9: tests/bluetooth/qualification/ICS_Zephyr_Bluetooth_Host.bqw:16: trailing whitespace. 5ca1ed29589fda348a49a7e70b593e1ec0add7a9: tests/bluetooth/qualification/ICS_Zephyr_Bluetooth_Host.bqw:17: trailing whitespace. 5ca1ed29589fda348a49a7e70b593e1ec0add7a9: tests/bluetooth/qualification/ICS_Zephyr_Bluetooth_Host.bqw:18: trailing whitespace. 5ca1ed29589fda348a49a7e70b593e1ec0add7a9: tests/bluetooth/qualification/ICS_Zephyr_Bluetooth_Host.bqw:19: trailing whitespace. 5ca1ed29589fda348a49a7e70b593e1ec0add7a9: tests/bluetooth/qualification/ICS_Zephyr_Bluetooth_Host.bqw:20: trailing whitespace. 5ca1ed29589fda348a49a7e70b593e1ec0add7a9: tests/bluetooth/qualification/ICS_Zephyr_Bluetooth_Host.bqw:21: trailing whitespace. 5ca1ed29589fda348a49a7e70b593e1ec0add7a9: tests/bluetooth/qualification/ICS_Zephyr_Bluetooth_Host.bqw:22: trailing whitespace. 5ca1ed29589fda348a49a7e70b593e1ec0add7a9: tests/bluetooth/qualification/ICS_Zephyr_Bluetooth_Host.bqw:23: trailing whitespace. 5ca1ed29589fda348a49a7e70b593e1ec0add7a9: tests/bluetooth/qualification/ICS_Zephyr_Bluetooth_Host.bqw:24: trailing whitespace. 5ca1ed29589fda348a49a7e70b593e1ec0add7a9: tests/bluetooth/qualification/ICS_Zephyr_Bluetooth_Host.bqw:25: trailing whitespace. 5ca1ed29589fda348a49a7e70b593e1ec0add7a9: tests/bluetooth/qualification/ICS_Zephyr_Bluetooth_Host.bqw:26: trailing whitespace. 5ca1ed29589fda348a49a7e70b593e1ec0add7a9: tests/bluetooth/qualification/ICS_Zephyr_Bluetooth_Host.bqw:27: trailing whitespace. 5ca1ed29589fda348a49a7e70b593e1ec0add7a9: tests/bluetooth/qualification/ICS_Zephyr_Bluetooth_Host.bqw:28: trailing whitespace. 5ca1ed29589fda348a49a7e70b593e1ec0add7a9: tests/bluetooth/qualification/ICS_Zephyr_Bluetooth_Host.bqw:29: trailing whitespace. 5ca1ed29589fda348a49a7e70b593e1ec0add7a9: tests/bluetooth/qualification/ICS_Zephyr_Bluetooth_Host.bqw:30: trailing whitespace. 5ca1ed29589fda348a49a7e70b593e1ec0add7a9: tests/bluetooth/qualification/ICS_Zephyr_Bluetooth_Host.bqw:33: trailing whitespace. 5ca1ed29589fda348a49a7e70b593e1ec0add7a9: tests/bluetooth/qualification/ICS_Zephyr_Bluetooth_Host.bqw:34: trailing whitespace. 5ca1ed29589fda348a49a7e70b593e1ec0add7a9: tests/bluetooth/qualification/ICS_Zephyr_Bluetooth_Host.bqw:35: trailing whitespace. 5ca1ed29589fda348a49a7e70b593e1ec0add7a9: tests/bluetooth/qualification/ICS_Zephyr_Bluetooth_Host.bqw:36: trailing whitespace. 5ca1ed29589fda348a49a7e70b593e1ec0add7a9: tests/bluetooth/qualification/ICS_Zephyr_Bluetooth_Host.bqw:37: trailing whitespace. 5ca1ed29589fda348a49a7e70b593e1ec0add7a9: tests/bluetooth/qualification/ICS_Zephyr_Bluetooth_Host.bqw:42: trailing whitespace. 5ca1ed29589fda348a49a7e70b593e1ec0add7a9: tests/bluetooth/qualification/ICS_Zephyr_Bluetooth_Host.bqw:43: trailing whitespace. 5ca1ed29589fda348a49a7e70b593e1ec0add7a9: tests/bluetooth/qualification/ICS_Zephyr_Bluetooth_Host.bqw:44: trailing whitespace. 5ca1ed29589fda348a49a7e70b593e1ec0add7a9: tests/bluetooth/qualification/ICS_Zephyr_
Run compliance checks on patch series (PR): Identity.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#commit-guidelines for more details 9734ac7d760310ab13fce0db0928beab2a63e1b7: author email (Andrzej Kuros <[email protected]>) needs to match one of the signed-off-by entries. f3987196cb3f644f48db034628ad18d20405fbea: author email (Andrzej Kuros <[email protected]>) needs to match one of the signed-off-by entries. cd4c6a16f07c2ef6ac81f5c54988d292332cd261: author email (F. Ramu <[email protected]>) needs to match one of the signed-off-by entries. e17d094f4164f2567c0aeb9d1514895392bf4a6b: author email (Francois RAMU <[email protected]>) needs to match one of the signed-off-by entries. 0b4e9a4c57075a0bad7374b11e657138ccd479e5: author email (Stine Akredalen <[email protected]>) needs to match one of the signed-off-by entries. 44cca1512a4d734df1ae12178931a036fb940457: author email (Francois RAMU <[email protected]>) needs to match one of the signed-off-by entries. ea3e1403efff730e78e42843cf515fd259d689b4: author email (Stine Akredalen <[email protected]>) needs to match one of the signed-off-by entries. db6f515a7cf17cc7c63c96499d6c8bb74387e729: author email (Andrzej Kuros <[email protected]>) needs to match one of the signed-off-by entries. 7d97c28b8479782120e27386890e5acc662b3c38: author email (Andrzej Kuros <[email protected]>) needs to match one of the signed-off-by entries. 1f9b47d3e55f18d5527d6d5726c855c9bab42cb1: author email (Andrzej Kuros <[email protected]>) needs to match one of the signed-off-by entries. 796bfee8de94e9e139a8941e0036b3450fe67d57: author email (Mateusz Holenko <[email protected]>) needs to match one of the signed-off-by entries. a1aa58c08a7b735763523933ca689f5d2762b1d0: author email (Mateusz Holenko <[email protected]>) needs to match one of the signed-off-by entries. 19b0569c1d8c37f2f979d060725ae94fc304aaa9: author email (Andrzej Kuros <[email protected]>) needs to match one of the signed-off-by entries.
Run compliance checks on patch series (PR): ImageSize.txt#L1
Check the size of image files. Image file too large: boards/intel/socfpga_std/cyclonev_socdk/doc/img/cyclonev_socdk.jpg reduce size to less than 100kB
Run compliance checks on patch series (PR): Pylint.txt#L1
See https://www.pylint.org/ for more details E0611:No name 'TEST_DATA' in module 'conftest' (no-name-in-module) File:doc/develop/test/twister/sample_blackbox_test.py Line:13 Column:0 E0611:No name 'ZEPHYR_BASE' in module 'conftest' (no-name-in-module) File:doc/develop/test/twister/sample_blackbox_test.py Line:13 Column:0 E0611:No name 'testsuite_filename_mock' in module 'conftest' (no-name-in-module) File:doc/develop/test/twister/sample_blackbox_test.py Line:13 Column:0 E0611:No name 'other_constants' in module 'constants' (no-name-in-module) File:scripts/generate_usb_vif/constants/xml_constants.py Line:8 Column:0 E0611:No name 'vif_element_constants' in module 'constants' (no-name-in-module) File:scripts/generate_usb_vif/constants/xml_constants.py Line:8 Column:0 W0611:Unused natsorted imported from natsort (unused-import) File:scripts/pylib/twister/twisterlib/hardwaremap.py Line:16 Column:0 E1120:No value for argument 'target' in method call (no-value-for-parameter) File:scripts/tests/twister/test_platform.py Line:118 Column:8 E1120:No value for argument 'aliases' in method call (no-value-for-parameter) File:scripts/tests/twister/test_platform.py Line:118 Column:8 E1120:No value for argument 'data' in method call (no-value-for-parameter) File:scripts/tests/twister/test_platform.py Line:118 Column:8 C0117:Consider changing "not testinstance < testinstance_copy" to "testinstance >= testinstance_copy" (unnecessary-negation) File:scripts/tests/twister/test_testinstance.py Line:359 Column:11 C0117:Consider changing "not testinstance_copy < testinstance" to "testinstance_copy >= testinstance" (unnecessary-negation) File:scripts/tests/twister/test_testinstance.py Line:360 Column:11 C0201:Consider iterating the dictionary directly instead of calling .keys() (consider-iterating-dictionary) File:scripts/tests/twister/test_testplan.py Line:848 Column:37 E0611:No name 'TEST_DATA' in module 'conftest' (no-name-in-module) File:scripts/tests/twister_blackbox/test_addon.py Line:19 Column:0 E0611:No name 'sample_filename_mock' in module 'conftest' (no-name-in-module) File:scripts/tests/twister_blackbox/test_addon.py Line:19 Column:0 E0611:No name 'testsuite_filename_mock' in module 'conftest' (no-name-in-module) File:scripts/tests/twister_blackbox/test_addon.py Line:19 Column:0 E0611:No name 'ZEPHYR_BASE' in module 'conftest' (no-name-in-module) File:scripts/tests/twister_blackbox/test_disable.py Line:16 Column:0 E0611:No name 'TEST_DATA' in module 'conftest' (no-name-in-module) File:scripts/tests/twister_blackbox/test_disable.py Line:16 Column:0 E0611:No name 'testsuite_filename_mock' in module 'conftest' (no-name-in-module) File:scripts/tests/twister_blackbox/test_disable.py Line:16 Column:0 E0611:No name 'TEST_DATA' in module 'conftest' (no-name-in-module) File:scripts/tests/twister_blackbox/test_quarantine.py Line:18 Column:0 E0611:No name 'testsuite_filename_mock' in module 'conftest' (no-name-in-module) File:scripts/tests/twister_blackbox/test_quarantine.py Line:18 Column:0 I0021:Useless suppression of 'assignment-from-no-return' (useless-suppression) File:scripts/utils/board_v1_to_v2.py Line:79 Column:0 E0611:No name 'RC_KERNEL_BIN' in module 'conftest' (no-name-in-module) File:scripts/west_commands/tests/test_bossac.py Line:15 Column:0 E0611:No name 'RC_KERNEL_HEX' in module 'conftest' (no-name-in-module) File:scripts/west_commands/tests/test_stm32cubeprogrammer.py Line:12 Column:0 E0611:No name 'RC_KERNEL_ELF' in module 'conftest' (no-name-in-module) File:scripts/west_commands/tests/test_stm32cubeprogrammer.py Line:12 Column:0 E0611:No name 'RC_KERNEL_ELF' in module 'conftest' (no-name-in-module) File:scripts/west_commands/tests/test_xsdb.py Line:9 Column:0
Run compliance checks on patch series (PR): Ruff.txt#L1
Check python files with ruff. Python lint error (F401) see https://docs.astral.sh/ruff/rules/unused-import:`natsort.natsorted` imported but unused File:scripts/pylib/twister/twisterlib/hardwaremap.py Line:16 Column:21 EndLine:16 EndColumn:30 Python lint error (I001) see https://docs.astral.sh/ruff/rules/unsorted-imports:Import block is un-sorted or un-formatted File:tests/lib/devicetree/memory_region_flags/pytest/test_memory_region_flags.py Line:4 Column:1 EndLine:10 EndColumn:1 Python lint error (E402) see https://docs.astral.sh/ruff/rules/module-import-not-at-top-of-file:Module level import not at top of file File:tests/lib/devicetree/memory_region_flags/pytest/test_memory_region_flags.py Line:14 Column:1 EndLine:14 EndColumn:30 Python lint error (E501) see https://docs.astral.sh/ruff/rules/line-too-long:Line too long (104 > 100) File:tests/lib/devicetree/memory_region_flags/pytest/test_memory_region_flags.py Line:67 Column:101 EndLine:67 EndColumn:105 Python format error:Run 'ruff format tests/lib/devicetree/memory_region_flags/pytest/test_memory_region_flags.py' File:tests/lib/devicetree/memory_region_flags/pytest/test_memory_region_flags.py
Run compliance checks on patch series (PR)
Process completed with exit code 1.
Run compliance checks on patch series (PR)
Process completed with exit code 1.
E0611: doc/develop/test/twister/sample_blackbox_test.py#L13
doc/develop/test/twister/sample_blackbox_test.py:13 No name 'TEST_DATA' in module 'conftest' (no-name-in-module)
E0611: doc/develop/test/twister/sample_blackbox_test.py#L13
doc/develop/test/twister/sample_blackbox_test.py:13 No name 'ZEPHYR_BASE' in module 'conftest' (no-name-in-module)
E0611: doc/develop/test/twister/sample_blackbox_test.py#L13
doc/develop/test/twister/sample_blackbox_test.py:13 No name 'testsuite_filename_mock' in module 'conftest' (no-name-in-module)
E0611: scripts/generate_usb_vif/constants/xml_constants.py#L8
scripts/generate_usb_vif/constants/xml_constants.py:8 No name 'other_constants' in module 'constants' (no-name-in-module)
E0611: scripts/generate_usb_vif/constants/xml_constants.py#L8
scripts/generate_usb_vif/constants/xml_constants.py:8 No name 'vif_element_constants' in module 'constants' (no-name-in-module)
E1120: scripts/tests/twister/test_platform.py#L118
scripts/tests/twister/test_platform.py:118 No value for argument 'target' in method call (no-value-for-parameter)
E1120: scripts/tests/twister/test_platform.py#L118
scripts/tests/twister/test_platform.py:118 No value for argument 'aliases' in method call (no-value-for-parameter)
E1120: scripts/tests/twister/test_platform.py#L118
scripts/tests/twister/test_platform.py:118 No value for argument 'data' in method call (no-value-for-parameter)
E0611: scripts/tests/twister_blackbox/test_addon.py#L19
scripts/tests/twister_blackbox/test_addon.py:19 No name 'TEST_DATA' in module 'conftest' (no-name-in-module)
E0611: scripts/tests/twister_blackbox/test_addon.py#L19
scripts/tests/twister_blackbox/test_addon.py:19 No name 'sample_filename_mock' in module 'conftest' (no-name-in-module)
W0611: scripts/pylib/twister/twisterlib/hardwaremap.py#L16
scripts/pylib/twister/twisterlib/hardwaremap.py:16 Unused natsorted imported from natsort (unused-import)
C0117: scripts/tests/twister/test_testinstance.py#L359
scripts/tests/twister/test_testinstance.py:359 Consider changing "not testinstance < testinstance_copy" to "testinstance >= testinstance_copy" (unnecessary-negation)
C0117: scripts/tests/twister/test_testinstance.py#L360
scripts/tests/twister/test_testinstance.py:360 Consider changing "not testinstance_copy < testinstance" to "testinstance_copy >= testinstance" (unnecessary-negation)
C0201: scripts/tests/twister/test_testplan.py#L848
scripts/tests/twister/test_testplan.py:848 Consider iterating the dictionary directly instead of calling .keys() (consider-iterating-dictionary)
I0021: scripts/utils/board_v1_to_v2.py#L79
scripts/utils/board_v1_to_v2.py:79 Useless suppression of 'assignment-from-no-return' (useless-suppression)

Artifacts

Produced during runtime
Name Size
compliance.xml
72.4 KB