cmake: openthread: change crypto check for prebuilt libs #1521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciejbaczmanski
requested review from
lmaciejonczyk,
edmont and
canisLupus1313
as code owners
This was referenced Oct 17, 2024
maciejbaczmanski
force-pushed
the
ot_moonlight_tfm
branch
from
61a74cf to
18a092b
Compare
Change approach on crypto checks for prebuilt libraries to compare generated configs instead of mbedtls header file. Signed-off-by: Maciej Baczmanski <[email protected]>
maciejbaczmanski
force-pushed
the
ot_moonlight_tfm
branch
from
18a092b to
6585027
Compare
ArekBalysNordic
approved these changes
Oct 22, 2024
|
|
||
| ###################### Crypto configuration ################## | ||
|
|
||
| CONFIG_MBEDTLS_AES_DECRYPT_ALT=y |
There was a problem hiding this comment.
We can think about it as a follow-up to this PR, but I wonder whether we can have the common configuration which is visible in all variants and versions, and have only the missing ones in each library. What do you think? Having it in this approach increases maintenance costs.
There was a problem hiding this comment.
I think that's a good idea! I'll create a follow up task for that as I doubt we will make this in time for 2.8.0
kkasperczyk-no
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change approach on crypto checks for prebuilt libraries to compare generated configs instead of mbedtls header file.