Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nrf_rpc: remove sending from rx thread #1493

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

alxelax
Copy link
Contributor

@alxelax alxelax commented Oct 2, 2024

Commit removes any data sending over serial transport from rx thread and adds sending over allocated pool of threads for incoming data execution.
The reason of this: if sending requires some acknowledgements then deadlock of rx thread happens.

@CLAassistant
Copy link

CLAassistant commented Oct 2, 2024

CLA assistant check
All committers have signed the CLA.

@alxelax
Copy link
Contributor Author

alxelax commented Oct 2, 2024

@doki-nordic, @KAGA164 could any of you to take a look at changes?

Commit removes any data sending over serial transport from
rx thread and adds sending over allocated pool of threads
for incoming data execution.
The reason of this: if sending requires some acknowledgements
then deadlock of rx thread happens.

Signed-off-by: Aleksandr Khromykh <[email protected]>
@rlubos rlubos merged commit 1807c6e into nrfconnect:main Oct 3, 2024
4 checks passed
@alxelax alxelax deleted the sync_rpc_start branch October 3, 2024 09:33
tomchy added a commit to tomchy/sdk-nrfxlib that referenced this pull request Oct 29, 2024
In case of error, the group pointer may be set to NULL.
This reverts part of changes introduced in the following PR:
nrfconnect#1493

Ref: NCSDK-29976

Signed-off-by: Tomasz Chyrowicz <[email protected]>
tomchy added a commit to tomchy/sdk-nrf that referenced this pull request Oct 29, 2024
Update sdk-nrfxlib revision.
This reverts changes introduced in the following PRs:
nrfconnect/sdk-nrfxlib#1493
nrfconnect/sdk-nrfxlib#1506

Ref: NCSDK-19976

Signed-off-by: Tomasz Chyrowicz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants