nrf_wi: Fix TX power issue #1238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imapa
requested review from
krish2718,
sachinthegreen,
rado17 and
rlubos
as code owners
srkanordic
approved these changes
Mar 1, 2024
sachinthegreen
requested changes
Mar 1, 2024
| prf->temp_volt_backoff.hb_vbt_lt_vlow = 0; | ||
| prf->temp_volt_backoff.lb_vbt_lt_low = 0; | ||
| prf->temp_volt_backoff.hb_vbt_lt_low = 0; | ||
| #endif |
There was a problem hiding this comment.
Suggested change
| #endif | |
| #endif /* CONFIG_NRF700X_RADIO_TEST */ |
| prf->temp_volt_backoff.lb_vbt_lt_vlow = 0; | ||
| prf->temp_volt_backoff.hb_vbt_lt_vlow = 0; | ||
| prf->temp_volt_backoff.lb_vbt_lt_low = 0; | ||
| prf->temp_volt_backoff.hb_vbt_lt_low = 0; |
There was a problem hiding this comment.
Why is it needed to set some values to 0 specifically. Why can't prf be initialized to all 0 at the beginning of the function and only the specific values updated later in the function?
sachinthegreen
requested changes
Mar 1, 2024
sachinthegreen
requested changes
Mar 1, 2024
| @@ -1041,6 +1049,7 @@ int nrf_wifi_phy_rf_params_init(struct nrf_wifi_osal_priv *opriv, | |||
| prf->temp_volt_backoff.hb_vbt_lt_vlow = QFN_HB_VBT_LT_VLOW; | |||
| prf->temp_volt_backoff.lb_vbt_lt_low = QFN_LB_VBT_LT_LOW; | |||
| prf->temp_volt_backoff.hb_vbt_lt_low = QFN_HB_VBT_LT_LOW; | |||
| #endif | |||
There was a problem hiding this comment.
Suggested change
| #endif | |
| #endif |
Suggested change
| #endif | |
| #endif /* ~CONFIG_NRF700X_RADIO_TEST */ |
| @@ -1009,6 +1015,7 @@ int nrf_wifi_phy_rf_params_init(struct nrf_wifi_osal_priv *opriv, | |||
| prf->temp_volt_backoff.hb_vbt_lt_vlow = CSP_HB_VBT_LT_VLOW; | |||
| prf->temp_volt_backoff.lb_vbt_lt_low = CSP_LB_VBT_LT_LOW; | |||
| prf->temp_volt_backoff.hb_vbt_lt_low = CSP_HB_VBT_LT_LOW; | |||
| #endif | |||
There was a problem hiding this comment.
Suggested change
| #endif | |
| #endif /* !CONFIG_NRF700X_RADIO_TEST */ |
imapa
force-pushed
the
shel-2533
branch
2 times, most recently
from
5721a6b to
68dc1b6
Compare
sachinthegreen
approved these changes
Mar 1, 2024
[SHEL-2533]: The problem of TX output power disparity has been resolved, which occurs when the default power is set without utilizing the TX power command, and the power is explicitly set using the TX power command through the Radio test application. Signed-off-by: Mahammadyunus Patil <[email protected]>
It happened accidentally. Code is now rebased. |
rado17
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SHEL-2533: The problem of TX output power disparity has been resolved, which occurs when the default power is set without utilizing the TX power command, and the power is explicitly set using the TX power command through the Radio test application.