Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

manifest: support sdsc binary bundle 0.6.8 (SDFW 8.0.1 SCFW 3.0.0) #18078

Merged
merged 6 commits into from
Oct 30, 2024
Merged

manifest: support sdsc binary bundle 0.6.8 (SDFW 8.0.1 SCFW 3.0.0) #18078

merged 6 commits into from
Oct 30, 2024

Conversation

hakonfam
Copy link
Contributor

@hakonfam hakonfam commented Oct 22, 2024 •
edited by miha-nordic
Loading

Ref: NCSDK-NONE

test-sdk-nrf: sdk-nrf-pr-18078

@hakonfam hakonfam added the CI-disable Disable CI for this PR label Oct 22, 2024
@github-actions github-actions bot added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Oct 22, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Oct 22, 2024 •
edited
Loading

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
nrfxlib nrfconnect/sdk-nrfxlib@673c2dd nrfconnect/sdk-nrfxlib@1e25b05 (main) nrfconnect/[email protected]
suit-generator nrfconnect/[email protected] nrfconnect/suit-generator@c2e394f nrfconnect/[email protected]
zephyr nrfconnect/sdk-zephyr@c1dc2ca nrfconnect/sdk-zephyr@08f1c5b (main) nrfconnect/[email protected]

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Oct 22, 2024 •
edited
Loading

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 38

Inputs:

Sources:

more details

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (0)

Outputs:

Toolchain

Version:
Build docker image:

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ❌ Toolchain
  • ❌ Build twister
  • ❌ Integration tests

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@hakonfam hakonfam force-pushed the sdsc-bundle-2.8.0-rc1 branch from 1914c84 to 116e2ef Compare October 22, 2024 08:54
@ns-tolu ns-tolu added this to the 2.8.0 milestone Oct 22, 2024
@jonathannilsen jonathannilsen force-pushed the sdsc-bundle-2.8.0-rc1 branch 2 times, most recently from d51d8c5 to e6fab58 Compare October 23, 2024 11:35
@hakonfam hakonfam changed the title manifest: update sdk-zephyr to support binary bundle for 2.8.0 manifest: support sdsc binary bundle 0.6.7 (SDFW 8.0.0 SCFW 3.0.0) Oct 23, 2024
@jonathannilsen jonathannilsen force-pushed the sdsc-bundle-2.8.0-rc1 branch 2 times, most recently from d178252 to f3940c4 Compare October 23, 2024 14:17
@jonathannilsen jonathannilsen force-pushed the sdsc-bundle-2.8.0-rc1 branch 2 times, most recently from 9c0e5a6 to 947f20b Compare October 24, 2024 07:10
@miha-nordic miha-nordic added CI-all-test Run All integration tests and removed CI-disable Disable CI for this PR labels Oct 24, 2024
@hakonfam hakonfam force-pushed the sdsc-bundle-2.8.0-rc1 branch 2 times, most recently from 0d346f4 to 43fa95c Compare October 24, 2024 08:04
@hakonfam hakonfam marked this pull request as ready for review October 24, 2024 08:12
@hakonfam hakonfam requested review from a team as code owners October 24, 2024 08:12
@tomchy tomchy requested a review from robertstypa October 24, 2024 10:20
@jonathannilsen jonathannilsen changed the title manifest: support sdsc binary bundle 0.6.7 (SDFW 8.0.0 SCFW 3.0.0) manifest: support sdsc binary bundle 0.6.8 (SDFW 8.0.1 SCFW 3.0.0) Oct 28, 2024
@jonathannilsen jonathannilsen mentioned this pull request Oct 28, 2024
Merged
@hakonfam hakonfam force-pushed the sdsc-bundle-2.8.0-rc1 branch from 1ee8087 to c3b295f Compare October 29, 2024 05:38
@jaci-nordic
Copy link
Contributor

why is it approved if twister tests are not passing?

@hakonfam
Copy link
Contributor Author

why is it approved if twister tests are not passing?

We had two failures that were going to be quarantined. The failing tests will be addressed, so I guess the approvals is assuming that tests are good.

tejlmand
tejlmand approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@tejlmand tejlmand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

small nit on line length.
I feel some other lines might also be >100, so would be nice if you check those in addition.

samples/peripheral/802154_phy_test/modules/app_rpc/zephyr/Kconfig Outdated Show resolved Hide resolved
@hakonfam hakonfam force-pushed the sdsc-bundle-2.8.0-rc1 branch from c3b295f to 192bed3 Compare October 29, 2024 10:19
@hakonfam
Copy link
Contributor Author

hakonfam commented Oct 29, 2024 •
edited
Loading

Failing twister tests for 192bed3 related to TF-M are known to be red on main, so twister tests are all good.

@hakonfam hakonfam force-pushed the sdsc-bundle-2.8.0-rc1 branch 2 times, most recently from 77b3771 to ff713e4 Compare October 29, 2024 14:24
@hakonfam hakonfam requested review from miha-nordic and a team as code owners October 29, 2024 14:24
hakonfam and others added 3 commits October 29, 2024 17:37
@hakonfam
Revert "snippets: hw-flow-control: add nrf52"
4bb2507 
This reverts commit f65009c.

Signed-off-by: Håkon Amunsden <[email protected]>
@hakonfam
scripts: setuptools==75.2.0
3340816 
Ref: NCSDK-NONE
Signed-off-by: Håkon Amundsen <[email protected]>
@57300 @hakonfam
kconfig: Use SOC_NRF54H20_ENGB
1ff354f 
Certain Kconfigs were only enabled for or in relation to nRF54H20 EngC,
which is the default chip revision. Ensure that the same settings are
available on EngB.

Signed-off-by: Grzegorz Swiderski <[email protected]>
@hakonfam hakonfam force-pushed the sdsc-bundle-2.8.0-rc1 branch from ff713e4 to b4d5e96 Compare October 29, 2024 16:41
@NordicBuilder
Copy link
Contributor

Memory footprint analysis revealed the following potential issues

sample.matter.template.release[nrf7002dk/nrf5340/cpuapp]: High ROM usage: 812426[B] - link (cc: @kkasperczyk-no @ArekBalysNordic @markaj-nordic)

Note: This message is automatically posted and updated by the CI (latest/sdk-nrf/PR-18078/35)

@rlubos
Copy link
Contributor

rlubos commented Oct 30, 2024

@hakonfam Please update SHA and fix the compliance issue (commit author). This PR will need to be backported manually to the release branch

hakonfam and others added 3 commits October 30, 2024 09:09
@hakonfam
manifest: pull in dependencies for binary bundle for 2.8.0
a5298fb 
Pull in updates to several repositories to support the SDSC
bundle for NCS 2.8.0 and fix build issues with [email protected].

Signed-off-by: Håkon Amundsen <[email protected]>
Signed-off-by: Jonathan Nilsen <[email protected]>
@hakonfam
scripts: bump nrf-regtool to 7.0.0
160f41a 
This is needed for new UICR layout.

Signed-off-by: Håkon Amundsen <[email protected]>
@jonathannilsen @hakonfam
samples: smp_transfer: don't reserve app/radio shared memory from app
90a437b 
Don't configure access to cpuapp/cpurad shared memory from the cpuapp
side, as the shared access is configured by the cpurad side.

Signed-off-by: Jonathan Nilsen <[email protected]>
@hakonfam hakonfam force-pushed the sdsc-bundle-2.8.0-rc1 branch from b4d5e96 to 90a437b Compare October 30, 2024 08:09
@NordicBuilder NordicBuilder removed the DNM label Oct 30, 2024
@rlubos rlubos merged commit ccad1a9 into nrfconnect:main Oct 30, 2024
10 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kszromek-nordic kszromek-nordic kszromek-nordic approved these changes

@robertstypa robertstypa robertstypa approved these changes

@miha-nordic miha-nordic miha-nordic approved these changes

@nordic-segl nordic-segl nordic-segl approved these changes

@jangalda-nsc jangalda-nsc jangalda-nsc approved these changes

@tejlmand tejlmand tejlmand approved these changes

@tomchy tomchy tomchy approved these changes

@ahasztag ahasztag Awaiting requested review from ahasztag

@nordic-piks nordic-piks Awaiting requested review from nordic-piks

Assignees
No one assigned
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. CI-all-test Run All integration tests CI-force-downstream manifest manifest-nrfxlib manifest-suit-generator manifest-zephyr
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.