-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
matter: include EXTRAVERSION in Matter software version string #17787
Conversation
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 51e20dea0bdb5a6c5ce6fd04157e51d76603e08c more detailssdk-nrf:
matter:
Github labels
List of changed files detected by CI (6)
Outputs:ToolchainVersion: 3dd8985b56 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Damian-Nordic!
I think we need slightly to modify the documentation here: https://docs.nordicsemi.com/bundle/ncs-latest/page/nrf/protocols/matter/end_product/versioning.html
We did ignore the extra string previously to have parity between BLE and Matter OTA images. Saying this, I think it's better to have an option to define this extra string even though it's not easily doable for BLE.
@doublemis1 could you check if some tests need adjustments?
8fa9308
to
884271e
Compare
884271e
to
438ff82
Compare
438ff82
to
99b9452
Compare
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst
Outdated
Show resolved
Hide resolved
Switch the Matter software version string from APP_VERSION_TWEAK_STRING to APP_VERSION_EXTENDED_STRING. Signed-off-by: Damian Krolik <[email protected]>
99b9452
to
51e20de
Compare
Switch the Matter software version string from
APP_VERSION_TWEAK_STRING to APP_VERSION_EXTENDED_STRING.