Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wifi: Fixes for recovery stress tests #17294

Merged
merged 3 commits into from
Sep 16, 2024

Conversation

krish2718
Copy link
Contributor

@krish2718 krish2718 commented Sep 12, 2024

  • The RPU context lock is not unlocked this is causing recovery to be stuck waiting for the lock.
  • Fix the improper re-initialization of RPU context lock
  • FW: Fix recovery reset for every TX command

The RPU context lock is not unlocked this is causing recovery to be
stuck waiting for the lock.

Signed-off-by: Chaitanya Tata <[email protected]>
@krish2718 krish2718 requested a review from krga2022 September 12, 2024 09:16
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Sep 12, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Sep 12, 2024

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite
test-fw-nrfconnect-chip X
test-sdk-wifi X

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

@krga2022 krga2022 added the wifi-qa-required Needs an Approval from Wi-Fi QA team before merging. label Sep 12, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Sep 12, 2024

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
nrfxlib nrfconnect/sdk-nrfxlib@0d57997 nrfconnect/sdk-nrfxlib@10f7478 (v2.6-branch) nrfconnect/[email protected]

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@krish2718 krish2718 changed the title drivers: wifi: Fix missing unlock for stats drivers: wifi: Fixes for recovery + stats collect race conditions Sep 13, 2024
@krish2718 krish2718 changed the title drivers: wifi: Fixes for recovery + stats collect race conditions wifi: Fixes for recovery + stats collect race conditions Sep 13, 2024
@krish2718 krish2718 changed the title wifi: Fixes for recovery + stats collect race conditions wifi: Fixes for recovery stress tests Sep 13, 2024
@bama-nordic bama-nordic removed the DNM label Sep 13, 2024
@krga2022 krga2022 removed the wifi-qa-required Needs an Approval from Wi-Fi QA team before merging. label Sep 16, 2024
@krga2022
Copy link
Contributor

All Wi-Fi tests are done. There are no regressions.

Absorb Watchdog timer related fixes.

Signed-off-by: Praveen Kankipati <[email protected]>
The mutex is used to protect RPU zephyr context which gets modified for
every interface down and up (including recovery), so, it was being
re-initialized but also used to protect down and up which is a bug.

Move the re-initialization to the driver entry so that it happens only
once and we can properly use the mutext for down and up protection.

Signed-off-by: Chaitanya Tata <[email protected]>
@rlubos rlubos merged commit 9a6c755 into nrfconnect:v2.6-branch Sep 16, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. manifest manifest-nrfxlib
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants