-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wifi: Fixes for recovery stress tests #17294
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
krish2718
commented
Sep 12, 2024
•
edited
Loading
edited
- The RPU context lock is not unlocked this is causing recovery to be stuck waiting for the lock.
- Fix the improper re-initialization of RPU context lock
- FW: Fix recovery reset for every TX command
The RPU context lock is not unlocked this is causing recovery to be stuck waiting for the lock. Signed-off-by: Chaitanya Tata <[email protected]>
krish2718
requested review from
sachinthegreen,
rado17 and
rlubos
as code owners
September 12, 2024 09:16
github-actions
bot
added
the
changelog-entry-required
Update changelog before merge. Remove label if entry is not needed or already added.
label
Sep 12, 2024
sachinthegreen
approved these changes
Sep 12, 2024
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
krga2022
added
the
wifi-qa-required
Needs an Approval from Wi-Fi QA team before merging.
label
Sep 12, 2024
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
kspraveeen
force-pushed
the
fix_unlock
branch
from
September 12, 2024 14:38
d88caf1
to
20410ec
Compare
krish2718
changed the title
drivers: wifi: Fix missing unlock for stats
drivers: wifi: Fixes for recovery + stats collect race conditions
Sep 13, 2024
krish2718
changed the title
drivers: wifi: Fixes for recovery + stats collect race conditions
wifi: Fixes for recovery + stats collect race conditions
Sep 13, 2024
krish2718
changed the title
wifi: Fixes for recovery + stats collect race conditions
wifi: Fixes for recovery stress tests
Sep 13, 2024
krish2718
force-pushed
the
fix_unlock
branch
from
September 13, 2024 10:18
d19fcff
to
c923b15
Compare
sachinthegreen
approved these changes
Sep 13, 2024
rado17
approved these changes
Sep 13, 2024
bama-nordic
approved these changes
Sep 13, 2024
krga2022
approved these changes
Sep 16, 2024
krga2022
removed
the
wifi-qa-required
Needs an Approval from Wi-Fi QA team before merging.
label
Sep 16, 2024
All Wi-Fi tests are done. There are no regressions. |
Absorb Watchdog timer related fixes. Signed-off-by: Praveen Kankipati <[email protected]>
The mutex is used to protect RPU zephyr context which gets modified for every interface down and up (including recovery), so, it was being re-initialized but also used to protect down and up which is a bug. Move the re-initialization to the driver entry so that it happens only once and we can properly use the mutext for down and up protection. Signed-off-by: Chaitanya Tata <[email protected]>
krish2718
force-pushed
the
fix_unlock
branch
from
September 16, 2024 07:42
c923b15
to
f7c8cb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changelog-entry-required
Update changelog before merge. Remove label if entry is not needed or already added.
manifest
manifest-nrfxlib
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.