-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
entropy: Add PSA rng as the entropy provider for the nrf54h20 #17200
base: main
Are you sure you want to change the base?
Conversation
The following west manifest projects have changed revision in this Pull Request:
⛔ DNM label due to: 1 project with PR revision Note: This message is automatically posted and updated by the Manifest GitHub Action. |
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: ea4ffc44e13784cc7f5d14d675270d2d216022ff more detailssdk-nrf:
nrfxlib:
zephyr:
Github labels
List of changed files detected by CI (40)
Outputs:ToolchainVersion: b77d8c1312 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
387c99f
to
1a1154a
Compare
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
114059e
to
6ed58b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again in this PR you have a commit that is later reverted (nrf_security: Enabled by default for nRF54H20
)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are lots of complex additions in this PR that seem to be tailored towards a special case without PSA crypto which is the default enabled and default supported in nRF54H20 devices
b8fb7cd
to
7e9300c
Compare
fff3fcc
to
403bd6f
Compare
e078363
to
d480f52
Compare
80466dd
to
3f4a587
Compare
Make all PSA drivers depend on the OBERON_PSA_CORE since we cannot use the drivers without it. Signed-off-by: Georgios Vasilakis <[email protected]>
3f4a587
to
33b84f0
Compare
Brings Zephyr changes which automatically enable the PSA crypto as the entropy generator for Zephyr. Signed-off-by: Georgios Vasilakis <[email protected]>
Add configuration to allow enabling the SSF PSA client when nrf_security is not enabled. This is particularly useful for the applications that only want to use the PSA rng and no other crypto. Enabling nrf_security in these applications will result to an increased application footprint and configuration complexity without any reason. This configuration provides the PSA implementation from the secure domain through the SSF client and it has no configurability yet. So there is no need to enforce NRF_SECURITY with this configuration. Signed-off-by: Georgios Vasilakis <[email protected]>
Add overlay to reduce the footprint of the matter_bridge application. Signed-off-by: Georgios Vasilakis <[email protected]>
Remove prng dts node since this is removed from the nrf54h20 board file. Signed-off-by: Georgios Vasilakis <[email protected]>
Remove the call to the ssf_psa_crypto_init since the psa_crypto is initialiazed in SDFW and it doesn't need to get initialized from the application. Signed-off-by: Georgios Vasilakis <[email protected]>
Disable the IPC and bellboard nodes since these tests don't use communication between domains. Signed-off-by: Georgios Vasilakis <[email protected]>
In a comment, tHe -> The Signed-off-by: Georgios Vasilakis <[email protected]>
Initialize the ssf_client earlier during the boot process during post kernel. ssf_client needs to be initialized before the CONFIG_NRF_802154_SER_RADIO_INIT_PRIO since it is used by the "nRF IEEE 802.15.4" protocol. It also needs to be initialied after the IPC IPC_SERVICE_REG_BACKEND_PRIORITY since the IPC expects the protocol to be initialized. Failing to do that will also trigger an assertion in Zephyr. Signed-off-by: Georgios Vasilakis <[email protected]>
Use nrf_rpc_init_group when ssf_client is being initalized since it will happen before other nrf_rpc groups are initialized. Signed-off-by: Georgios Vasilakis <[email protected]>
Disable the cpusec related nodes in the multicore benchmark since it increases power consumption and IPC communication with secure domain is not needed for this test. Signed-off-by: Georgios Vasilakis <[email protected]>
The cpuapp_ram0x_region has been changed in the global dtsi file in Zephyr and we need to align all dts overlay entries to that change. Signed-off-by: Arkadiusz Balys <[email protected]>
Updates the nrf_rpc library to allow initialization of single nrf_rpc groups. Signed-off-by: Georgios Vasilakis <[email protected]>
This sample require entropy from Zephyr, in nRF54h20 this is provided by PSA RNG driver and from the secure domain. The PSA RNG driver brings IPC dependencies which increase the flash footprint of this sample and this was not an acceptable increase for the mainttainers of the sample. It was concluded that as a temporary solution this sample will keep using the non cryptographically secure, deterministic software RNG. The dependency on the PRNG node needs to be removed later and it is tracked in NCSDK-30805. Signed-off-by: Georgios Vasilakis <[email protected]>
Enabling real entropy for the radio core through the ssf_client and the secure domain increased the stack requirements of the hci_ipc used in this sample. I couldn't run THREAD_ANALYZER in this application because of flash overflows and other issues. I did practical tests with 50 byte intervals and I know that 900 bytes is the least memory that could boot the radio core. I updated this to have the same configuration as the ipc_radio (2048 bytes) application since the usage of the hci_ipc here will be replaced with the ipc_radio later. Signed-off-by: Georgios Vasilakis <[email protected]>
Add function nrf_rpc_os_fatal_error function to handle fatal_errors using the Zephyr's fatal error hanlding. Signed-off-by: Georgios Vasilakis <[email protected]>
33b84f0
to
ea4ffc4
Compare
Memory footprint analysis revealed the following potential issuessample.matter.template.release[nrf7002dk/nrf5340/cpuapp]: High ROM usage: 820770[B] - link (cc: @kkasperczyk-no @ArekBalysNordic @markaj-nordic) Note: This message is automatically posted and updated by the CI (latest/sdk-nrf/PR-17200/96) |
No description provided.