Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

manifest: Update zephyr to fix boot banner #15194

Closed
wants to merge 1 commit into from
Closed

manifest: Update zephyr to fix boot banner #15194

wants to merge 1 commit into from

Conversation

tejlmand
Copy link
Contributor

@tejlmand tejlmand commented May 7, 2024

Jira: NCSDK-27345

Update zephyr to include upstream change making boot banner weak. This ensures that linker will only pick the strong implementation of boot banner when llext is used.

@tejlmand tejlmand requested a review from carlescufi as a code owner May 7, 2024 09:08
@github-actions github-actions bot added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels May 7, 2024
@NordicBuilder
Copy link
Contributor

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
zephyr nrfconnect/sdk-zephyr@b5cf304 (main) nrfconnect/sdk-zephyr#1683 nrfconnect/sdk-zephyr#1683/files

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented May 7, 2024 •
edited
Loading

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite
desktop52_verification X
test-fw-nrfconnect-fem X
test-fw-nrfconnect-nfc X
test-fw-nrfconnect-nrf-iot_thingy91 X
test-fw-nrfconnect-rpc X
test-fw-nrfconnect-rs X
test-low-level X
test-sdk-find-my X

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

@tejlmand tejlmand requested a review from katgiadla May 7, 2024 09:16
@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

katgiadla
katgiadla approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@katgiadla katgiadla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works on-target

@nordic-segl
Copy link
Contributor

Please merge as this fixes many failures in llext samples. Remaining failure in
native_posix:tests/bluetooth/shell/bluetooth.shell.power_control_request.tests/bluetooth/shell/bluetooth.shell.power_control_request
is also visible in other PRs.

@tejlmand
manifest: Update zephyr to fix boot banner
51ebe69 
Jira: NCSDK-27345

Update zephyr to include upstream change making boot banner weak.
This ensures that linker will only pick the strong implementation of
boot banner when llext is used.

Signed-off-by: Torsten Rasmussen <[email protected]>
@tejlmand tejlmand force-pushed the weak_boot_banner branch from ea2cbaf to 51ebe69 Compare May 8, 2024 07:44
@nordic-babu nordic-babu self-requested a review May 8, 2024 08:35
@nordic-segl
Copy link
Contributor

#14880 will include these changes too.

@tejlmand tejlmand closed this May 8, 2024
@tejlmand tejlmand deleted the weak_boot_banner branch May 8, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nordic-babu nordic-babu nordic-babu approved these changes

@nordic-segl nordic-segl nordic-segl approved these changes

@katgiadla katgiadla katgiadla approved these changes

@nordicjm nordicjm nordicjm approved these changes

@carlescufi carlescufi Awaiting requested review from carlescufi

Assignees
No one assigned
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. DNM manifest manifest-zephyr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tejlmand @NordicBuilder @nordic-segl @nordicjm @katgiadla @nordic-babu