Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modules: hostap: Add support for WPA Auto security #14896

Merged
merged 3 commits into from
Apr 23, 2024

Conversation

rado17
Copy link
Contributor

@rado17 rado17 commented Apr 16, 2024

Support WPA Auto security mode wherein supplicant can
implicitly choose one of WPA, WPA2 and WPA3 for association
with a network.

Fixes SHEL-1131.

@github-actions github-actions bot added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Apr 16, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Apr 16, 2024

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
zephyr nrfconnect/sdk-zephyr@849d51f nrfconnect/sdk-zephyr@f46813e nrfconnect/[email protected]

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Apr 16, 2024

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite
test-fw-nrfconnect-chip X
test-sdk-wifi X

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

modules/hostap/src/supp_api.c Outdated Show resolved Hide resolved
modules/hostap/src/supp_api.c Outdated Show resolved Hide resolved
Copy link
Contributor

@sachinthegreen sachinthegreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the commit description be :

"Support WPA Auto security mode wherein supplicant can
implicitly choose the highest security among WPA, WPA2 and WPA3 for association
with a network based on network support." ?

@rado17 rado17 force-pushed the multi_sec_config branch from 8a05f50 to 3daed92 Compare April 17, 2024 08:03
@rado17 rado17 force-pushed the multi_sec_config branch from 3daed92 to 45ff0ee Compare April 17, 2024 09:46
@rado17 rado17 requested a review from sachinthegreen April 17, 2024 12:13
@rado17 rado17 force-pushed the multi_sec_config branch 2 times, most recently from 0bea90b to affc498 Compare April 18, 2024 12:30
@rado17 rado17 force-pushed the multi_sec_config branch from affc498 to 7e70d0f Compare April 19, 2024 06:19
@NordicBuilder NordicBuilder removed the DNM label Apr 19, 2024
@rado17 rado17 added the DNM label Apr 19, 2024
@github-actions github-actions bot added the doc-required PR must not be merged without tech writer approval. label Apr 19, 2024
@NordicBuilder NordicBuilder removed the DNM label Apr 19, 2024
@rado17 rado17 force-pushed the multi_sec_config branch 2 times, most recently from 6e27d69 to 8479d6f Compare April 19, 2024 09:38
@krish2718 krish2718 requested a review from richabp April 19, 2024 15:56
samples/wifi/shell/README.rst Outdated Show resolved Hide resolved
samples/wifi/shell/README.rst Outdated Show resolved Hide resolved
samples/wifi/shell/README.rst Outdated Show resolved Hide resolved
@rado17 rado17 force-pushed the multi_sec_config branch from 8479d6f to 707c5e9 Compare April 22, 2024 07:45
@rado17 rado17 requested a review from richabp April 22, 2024 07:53
Copy link
Contributor

@richabp richabp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is any changelog entry required for this update, please add and for 2.6.1, add a comment in #14941.

@rado17 rado17 force-pushed the multi_sec_config branch from 707c5e9 to 7ac0595 Compare April 22, 2024 12:13
@github-actions github-actions bot removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Apr 22, 2024
@rado17 rado17 force-pushed the multi_sec_config branch from 7ac0595 to 2633ed1 Compare April 23, 2024 08:19
@github-actions github-actions bot removed the manifest label Apr 23, 2024
@rado17 rado17 requested a review from richabp April 23, 2024 08:19
rado17 added 3 commits April 23, 2024 15:43
Support WPA Auto security mode wherein supplicant can
implicitly choose the highest security among WPA, WPA2
and WPA3 for association with a network based on network support.

Fixes SHEL-1131.

Signed-off-by: Ravi Dondaputi <[email protected]>
The `connect` command has been updated to take key-value style
arguments. Update the description to include this information.

Fixes SHEL-2699.

Signed-off-by: Ravi Dondaputi <[email protected]>
Add changelog entry for the changes done to `wifi connect`
command.

Signed-off-by: Ravi Dondaputi <[email protected]>
@rado17 rado17 force-pushed the multi_sec_config branch from 2633ed1 to a7f2390 Compare April 23, 2024 10:15
@rlubos rlubos merged commit 048d6f7 into nrfconnect:main Apr 23, 2024
16 checks passed
Copy link

The backport to v2.6-branch failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-v2.6-branch v2.6-branch
# Navigate to the new working tree
cd .worktrees/backport-v2.6-branch
# Create a new branch
git switch --create backport-14896-to-v2.6-branch
# Cherry-pick the merged commits of this pull request and resolve the conflicts
git cherry-pick 048d6f767e5aee8f4a36c58aaef61abb9ee3c84f~3..048d6f767e5aee8f4a36c58aaef61abb9ee3c84f
# Push it to GitHub
git push --set-upstream origin backport-14896-to-v2.6-branch
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-v2.6-branch

Then, create a pull request where the base branch is v2.6-branch and the compare/head branch is backport-14896-to-v2.6-branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport v2.6-branch doc-required PR must not be merged without tech writer approval.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants