Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples: matter: update manifest and disable Read Client #13464

Merged
merged 1 commit into from
Dec 20, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions applications/matter_bridge/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,10 @@ endif
config EXPERIMENTAL
default y

# Enable Read Client functionality for all build configurations.
config CHIP_ENABLE_READ_CLIENT
default y

source "${ZEPHYR_CONNECTEDHOMEIP_MODULE_DIR}/config/nrfconnect/chip-module/Kconfig.features"
source "${ZEPHYR_CONNECTEDHOMEIP_MODULE_DIR}/config/nrfconnect/chip-module/Kconfig.defaults"
source "${ZEPHYR_BASE}/../nrf/samples/matter/common/src/bridge/Kconfig"
Expand Down
3 changes: 3 additions & 0 deletions applications/matter_bridge/prj_release.conf
Original file line number Diff line number Diff line change
Expand Up @@ -43,3 +43,6 @@ CONFIG_CHIP_NFC_COMMISSIONING=n
# Enable Factory Data feature
CONFIG_CHIP_FACTORY_DATA=y
CONFIG_CHIP_FACTORY_DATA_BUILD=y

# Enable the Read Client for binding purposes
CONFIG_CHIP_ENABLE_READ_CLIENT=y
Original file line number Diff line number Diff line change
Expand Up @@ -141,3 +141,12 @@ By default this Kconfig option is set to 1 second.
.. note::
The :kconfig:option:`CONFIG_CHIP_FACTORY_RESET_ERASE_NVS` Kconfig option is set to ``y`` by default.
To disable removing application-specific non-volatile data when the :kconfig:option:`CONFIG_CHIP_LAST_FABRIC_REMOVED_ERASE_AND_REBOOT` Kconfig option is selected, set the :kconfig:option:`CONFIG_CHIP_FACTORY_RESET_ERASE_NVS` Kconfig option to ``n``.

.. _ug_matter_configuring_read_client:

Read Client functionality
=========================

The Read Client functionality is used for reading attributes from another device in the Matter network.
This functionality is disabled by default for Matter samples in the |NCS|, except for ones that need to read attributes from the bound devices, such as the :ref:`matter_light_switch_sample` and :ref:`matter_thermostat_sample` samples, and the :ref:`matter_bridge_app` application.
Enable the feature if your device needs to be able to access attributes from a different device within the Matter network using, for example, bindings.
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ Matter
------

* Updated the page about :ref:`ug_matter_device_low_power_configuration` with the information about Intermittently Connected Devices (ICD) configuration.
* Added a Kconfig option for disabling or enabling :ref:`ug_matter_configuring_read_client`.

Matter fork
+++++++++++
Expand Down Expand Up @@ -360,6 +361,8 @@ Matter samples
* Defined common LED and button constants in the dedicated board configuration files.
* Created the Kconfig file for the Matter common directory.

* Disabled :ref:`ug_matter_configuring_read_client` in most Matter samples using the new :kconfig:option:`CONFIG_CHIP_ENABLE_READ_CLIENT` Kconfig option.

* :ref:`matter_lock_sample` sample:

* Fixed an issue that prevented nRF Toolbox for iOS in version 5.0.9 from controlling the sample using :ref:`nus_service_readme`.
Expand Down
4 changes: 4 additions & 0 deletions samples/matter/light_switch/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,10 @@ config NRF_WIFI_LOW_POWER

endif # CHIP_WIFI

# Enable Read Client functionality for all build configurations.
config CHIP_ENABLE_READ_CLIENT
default y

source "${ZEPHYR_CONNECTEDHOMEIP_MODULE_DIR}/config/nrfconnect/chip-module/Kconfig.features"
source "${ZEPHYR_CONNECTEDHOMEIP_MODULE_DIR}/config/nrfconnect/chip-module/Kconfig.defaults"
source "${ZEPHYR_BASE}/../nrf/samples/matter/common/src/Kconfig"
Expand Down
3 changes: 3 additions & 0 deletions samples/matter/thermostat/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@ config THERMOSTAT_SIMULATED_TEMPERATURE_CHANGE
help
If set to true, the simulated temperature is rising. If set to false, the simulated temperature is falling.

# Enable Read Client functionality for all build configurations.
config CHIP_ENABLE_READ_CLIENT
default y

# Sample configuration used for Thread networking
if NET_L2_OPENTHREAD
Expand Down
2 changes: 1 addition & 1 deletion west.yml
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ manifest:
- name: matter
repo-path: sdk-connectedhomeip
path: modules/lib/matter
revision: c84b2c43069a14c047e27f652dedb944d64c0a9c
revision: d95eb1d43d6e8247045d549802642ec66ad1d322
submodules:
- name: nlio
path: third_party/nlio/repo
Expand Down
Loading