Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wifi: Basic AP mode support #13449

Merged
merged 15 commits into from
Dec 19, 2023
Merged

wifi: Basic AP mode support #13449

merged 15 commits into from
Dec 19, 2023

Conversation

krish2718
Copy link
Contributor

Beaconing only

@github-actions github-actions bot added changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. manifest labels Dec 15, 2023
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Dec 15, 2023 •
edited
Loading

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
hostap nrfconnect/sdk-hostap@d8d1d6d nrfconnect/sdk-hostap@bd0564c (main) nrfconnect/[email protected]
nrfxlib nrfconnect/sdk-nrfxlib@f61d074 nrfconnect/sdk-nrfxlib@79ea425 (main) nrfconnect/[email protected]
zephyr nrfconnect/sdk-zephyr@8614671 nrfconnect/sdk-zephyr@4262130 (main) nrfconnect/[email protected]

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Dec 15, 2023 •
edited
Loading

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite
desktop52_verification X
test-fw-nrfconnect-chip X
test-fw-nrfconnect-fem X
test-fw-nrfconnect-nrf-iot_cloud X
test-fw-nrfconnect-nrf-iot_mosh X
test-fw-nrfconnect-nrf-iot_positioning X
test-fw-nrfconnect-nrf-iot_thingy91 X
test-fw-nrfconnect-nrf-iot_zephyr_lwm2m X
test-fw-nrfconnect-rpc X
test-fw-nrfconnect-rs X
test-fw-nrfconnect-thread X
test-sdk-find-my X
test-sdk-wifi X

test-sdk-wifi: added because there was no .github/test-spec.yml in 'hostap'

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

@krish2718
manifest: sdk-zephyr: Pull Wi-Fi shell improvements
5493c13 
Minor improvements for AP mode.

Signed-off-by: Chaitanya Tata <[email protected]>
@krish2718
manifest: sdk-hostap: Pull AP mode fixes
6ede77f 
Fixes to get basic AP beaconing.

Signed-off-by: Chaitanya Tata <[email protected]>
@krish2718
manifest: sdk-nrfxlib: Pull AP mode OS agnostic fixes
fb9906e 
Fixes for AP mode in OS agnostic code.

Signed-off-by: Chaitanya Tata <[email protected]>
@krish2718
modules: hostap: Add missing sources for AP mode
f1ac354 
These were missed in the original support.

Fixes SHEL-2256.

Signed-off-by: Chaitanya Tata <[email protected]>
@krish2718
modules: hostap: Fix the configuration macro
6f07767 
hostapd macros should be used directly without prefixing with CONFIG.

Fixes SHEL-2256.

Signed-off-by: Chaitanya Tata <[email protected]>
@krish2718
modules: hostap: Move WPA CLI commands to helper function
a2c18b8 
This prepares for the upcoming AP mode support and moves re-usable code
to a common helper function.

Signed-off-by: Chaitanya Tata <[email protected]>
@krish2718
modules: hostap: Remove unused variable
dad0fde 
WPA supplicant handle is not used anymore.

Signed-off-by: Chaitanya Tata <[email protected]>
@krish2718
drivers: wifi: Fix the dependency on WPA supplicant
4b7b76a 
AP mode needs corresponding WPA supplicant AP mode, so, fix the
dependency.

Signed-off-by: Chaitanya Tata <[email protected]>
@krish2718
modules: hostap: Basic AP mode support
7ddf5e5 
Implement AP mode Wi-Fi management operations.

Implements SHEL-2255.

Signed-off-by: Chaitanya Tata <[email protected]>
@krish2718
drivers: wifi: Add an event for set interface
678e376 
This is necessary to check if the set interface is success or failure.

Signed-off-by: Chaitanya Tata <[email protected]>
@krish2718
drivers: wifi: Store the interface name
ed331c4 
This is needed for many VIF FMAC commands, so, store it in the VIF
context for easier access.

Signed-off-by: Chaitanya Tata <[email protected]>
@krish2718
drivers: wifi: Implement AP beaconing support
f2fd3c5 
This adds basic AP beaconing support.

Implements SHEL-2257 partially.

Signed-off-by: Chaitanya Tata <[email protected]>
@krish2718
modules: hostap: Skip RSSI retrieval for AP mode
cf042cf 
RSSI is only applicable for STA mode, as for AP there are multiple
peers. This causes failure and unnecessary delay, so, just skip the
retrieval.

Signed-off-by: Chaitanya Tata <[email protected]>
@krish2718
samples: wifi: shell: Add AP build to twister
82175d1 
Now that we have basic AP support, add the build combination to twister.

Signed-off-by: Chaitanya Tata <[email protected]>
@krish2718
modules: hostap: Skip searching for exiting networks
d52d152 
Before starting AP mode, we don't need to search for existing networks
and join them, as the use-case is starting SoftAP.

This speeds up the AP mode operation significantly.

Signed-off-by: Chaitanya Tata <[email protected]>
@NordicBuilder NordicBuilder removed the DNM label Dec 19, 2023
@rlubos rlubos merged commit 563456e into nrfconnect:main Dec 19, 2023
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sachinthegreen sachinthegreen sachinthegreen approved these changes

@rado17 rado17 rado17 approved these changes

@rlubos rlubos Awaiting requested review from rlubos

@jukkar jukkar Awaiting requested review from jukkar

@carlescufi carlescufi Awaiting requested review from carlescufi

@tejlmand tejlmand Awaiting requested review from tejlmand

Assignees
No one assigned
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. manifest manifest-hostap manifest-nrfxlib manifest-zephyr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@krish2718 @NordicBuilder @rado17 @sachinthegreen @rlubos