This repository was archived by the owner on Nov 14, 2024. It is now read-only.
Fix POSIX build #75
Merged
Fix POSIX build #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krish2718
requested review from
sr1dh48r,
rlubos and
sachinthegreen
as code owners
rlubos
approved these changes
Mar 27, 2023
|
I thought this compiled successfully, but apparently not, so, please wait for proper fix. |
added 2 commits
March 28, 2023 20:58
With upstream commit [1] when CONFIG_POSIX_API is enabled then Zephyr's header are included before the `libc` headers causing issues as Zephyr doesn't support POSIX signal implementation. Resolve this by not using POSIX_API and add a negative dependency. [1] - zephyrproject-rtos/zephyr@43110dd Signed-off-by: Krishna T <[email protected]>
Without this the build fails, so, should be selected automatically rather than relying on the application. Signed-off-by: Krishna T <[email protected]>
sachinthegreen
approved these changes
Mar 29, 2023
jfischer-no
approved these changes
Mar 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per [1], newlibc now defines _ANSI_SOURCE to avoid POSIX conflicts, but as hostapd needs POSIX stuff from libc, need to enable this explicitly.
[1] - zephyrproject-rtos/zephyr#52739