This repository has been archived by the owner on Nov 14, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 29
[nrf noup] Conditionally compile wpa commands help strings. #161
Closed
markaj-nordic
wants to merge
1
commit into
nrfconnect:main
from
markaj-nordic:conditional_cmds_help_strings
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what will be easier to maintain in future.. but alternatively you can do:
And later:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to keep the original array not changed and just append the stripped one for possible further refactoring (or moving it to e.g. separate file). But personally I like Łukasz's idea much better. @krish2718 please decide what would be easier for you to maintain and I will act accordingly :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also prefer @LuDuda's suggestion but I would recommend going with this presently in the interest of time (also @krish2718 is out till 13th). We in the Wi-Fi driver team can take a relook at this post 2.6.0 and bring it in as an enhancement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, using a macro to compile out RO strings is good. And this commands is
nrf noup
anyway, as I didn't want to duplicate the commands, so, moved to a new filewpa_cli_cmds.c
which doesn't exist in the opensource, so, this is fine.