Skip to content
This repository has been archived by the owner on Nov 14, 2024. It is now read-only.

Log errors to check 4-way handshake failure #160

Closed
wants to merge 2 commits into from
Closed

Log errors to check 4-way handshake failure #160

wants to merge 2 commits into from

Conversation

krish2718
Copy link
Collaborator

No description provided.

krish2718 added 2 commits March 7, 2024 02:40
@krish2718
[nrf noup] zephyr: Log an error for PRF derivation failure
01ad78a 
This is the common failure that we see in case WPA supplicant or MbedTLS
runs out of heap.

Signed-off-by: Chaitanya Tata <[email protected]>
@krish2718
[nrf noup] zephyr: Log an error for MD type get failure
965952b 
This is also a common scenario in case SHA1 is disabled in the MbedTLS,
so, log an error.

Signed-off-by: Chaitanya Tata <[email protected]>
@krish2718 krish2718 added this to the 2.6.0 milestone Mar 6, 2024
@NordicBuilder NordicBuilder mentioned this pull request Mar 6, 2024
Closed
@SeppoTakalo
Copy link

Is this relevant for the release?
Seems quite minor change for just the logging.

@krish2718
Copy link
Collaborator Author

Is this relevant for the release? Seems quite minor change for just the logging.

Its minor, but this is based on feedback we have got from customers, and was missed in RC1, having errors logs help us quickly identify the issue as debug logs are disabled due to flash constraints.

@krish2718
Copy link
Collaborator Author

@SeppoTakalo please confirm if I can go ahead and merge it?

@SeppoTakalo
Copy link

Why is there no upstream PR?

I don't understand how the hostapp development model works, but my first assumption is that this is not a change that justifies [nrf noup] changes to be cumulated in our Git history.

@krish2718
Copy link
Collaborator Author

Why is there no upstream PR?

I don't understand how the hostapp development model works, but my first assumption is that this is not a change that justifies [nrf noup] changes to be cumulated in our Git history.

You are right, we do follow upstream first approach. But this was a bit last moment, I can convert to to up (though not supposed be used often) or we can drop this from 2.6.0, I will leave it to you.

@krish2718 krish2718 removed this from the 2.6.0 milestone Mar 7, 2024
@SeppoTakalo
Copy link

Drop from 2.6.0 as we are just trying to create RC.
Too many manifest changes still coming in.

Send this to upstream.

@krish2718 krish2718 closed this Mar 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sachinthegreen sachinthegreen sachinthegreen approved these changes

@jukkar jukkar jukkar approved these changes

@rado17 rado17 Awaiting requested review from rado17 rado17 is a code owner

@rlubos rlubos Awaiting requested review from rlubos rlubos is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@krish2718 @SeppoTakalo @jukkar @sachinthegreen