This repository has been archived by the owner on Nov 14, 2024. It is now read-only.
Backport OOM fixes to v2.5 #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixup! [nrf noup] Monitor supplicant state and inform applications Even though the payload is of fixed size, move it to the end for easier parsing. Signed-off-by: Chaitanya Tata <[email protected]>
fixup! [nrf noup] Monitor supplicant state and inform applications Incoming message has a pre-defined structure and isn't a arbitrary blob, so, use the structure to parse properly. This was working earlier as the payload was in the beginning of the structure, but if we ever end up with a longer message then we would see issues. Signed-off-by: Chaitanya Tata <[email protected]>
fixup! [nrf noup] Monitor supplicant state and inform applications The incoming message is payload + length, so, need to include size of the "length" field. Fixes SHEL-2250. Signed-off-by: Chaitanya Tata <[email protected]>
fixup! [nrf noup] Monitor supplicant state and inform applications Sender is sending the entire structure, and receiving one byte lesser results in two receive calls per-message, this screws up the message parsing. Fixes SHEL-2250. Signed-off-by: Chaitanya Tata <[email protected]>
fixup! [nrf noup] zephyr: Add support for global control interface The below fixes from non-global control interface are ported: 1. Dummy receive in case of memory allocation failures 2. Identify EoF and close the socket. Signed-off-by: Chaitanya Tata <[email protected]>
fixup! [nrf noup] zephyr: Add support for WPA CLI zephyr In some cases (interface is disabled) the control interface socket is closed but as we don't handle EoF control interface keeps receiving zero bytes from the socket continuously and this causes an infinite loop and starving other threads (even SHELL thread). So, treat 0 bytes recv as EoF as its a connected socket and unregister from eloop to avoid infinite loop of recv failures. Fixes SHEL-2320. Signed-off-by: Chaitanya Tata <[email protected]>
Relying on heap during OOM is bad, esp. for critical module like WPA supplicant, this can break the Wi-Fi. As the WPA supplicant stack is large enough and we have reduced the control interface sizes, move the buffers for control interface to stack or use static variable. The static variable is used to keep the changes to the common code of the WPA supplicant to a minimum compared to using stack. Fixes SHEL-2283. Signed-off-by: Chaitanya Tata <[email protected]>
This can be same as non-global control interface, for interface command the output is limited to 1024. Signed-off-by: Chaitanya Tata <[email protected]>
Relying on heap during OOM is bad, esp. for critical module like WPA supplicant, this can break the Wi-Fi. As the WPA supplicant stack is large enough and this buffer is free immediately after use, just use the stack. Fixes SHEL-2283. Signed-off-by: Chaitanya Tata <[email protected]>
krish2718
requested review from
jukkar,
rado17,
sachinthegreen and
rlubos
as code owners
sachinthegreen
approved these changes
Feb 26, 2024
krish2718
force-pushed
the
backport_oom_25
branch
2 times, most recently
from
4884203 to
f926cca
Compare
VivekUppunda
approved these changes
Feb 26, 2024
krish2718
force-pushed
the
backport_oom_25
branch
9 times, most recently
from
2e3c801 to
bffd005
Compare
krish2718
force-pushed
the
backport_oom_25
branch
3 times, most recently
from
6ce2863 to
d00fa7f
Compare
rado17
approved these changes
Feb 28, 2024
krish2718
force-pushed
the
backport_oom_25
branch
2 times, most recently
from
e9b02d5 to
db89851
Compare
fixup! [nrf noup] zephyr: Redesign the events passing to wpa_supplicant from driver The management frame structure in the WPA supplicant only has a pointer, so, it need a deep-copy before passing it to WPA supplicant, else driver ends up freeing causing invalid memory contents. Signed-off-by: Chaitanya Tata <[email protected]>
fixup! [nrf noup] zephyr: Redesign the events passing to wpa_supplicant from driver Fix a crash where the stack pointer from the driver call is passed directly over the socket for async processing and if its delayed then driver stack frame is destroyed, causing a crash. Copy the buffer from driver stack before passing over socket. Signed-off-by: Chaitanya Tata <[email protected]>
krish2718
force-pushed
the
backport_oom_25
branch
from
db89851 to
73bc6f8
Compare
fixup! [nrf noup] zephyr: Redesign the events passing to wpa_supplicant from driver Perform a deep copy of all pointers in the association response event. Fixes SHEL-2515. Signed-off-by: Chaitanya Tata <[email protected]>
fixup! [nrf noup] zephyr: Redesign the events passing to wpa_supplicant from driver The dynamic data for these events are not deep copied. Fixes SHEL-2515. Signed-off-by: Chaitanya Tata <[email protected]>
fixup![nrf noup] ci: Fix the paths The compliance should be run from hostap repo and not sdk-zephyr. And also disable few tests that won't work reliably. Signed-off-by: Chaitanya Tata <[email protected]>
krish2718
force-pushed
the
backport_oom_25
branch
from
73bc6f8 to
0085c4e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many customers are on v2.5 branch, and as these fixes help with Stress and Stability, backport for next point release.