This repository has been archived by the owner on Nov 14, 2024. It is now read-only.
[nrf noup] Update device name to nrf_wlan0 #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rado17
requested review from
krish2718,
jukkar,
sachinthegreen and
rlubos
as code owners
jukkar
suggested changes
Jan 29, 2024
There was a problem hiding this comment.
Hard coding something like the network interface name should be avoided. Better would be to get the network interface name from the used network interface and use that. Then when the device boots, the interface name could be set to nrf_wlan0.
You are now basically forking the code as this cannot be accepted upstream, and it will conflict the in future upstreaming efforts.
rado17
force-pushed
the
wifi_dt_device
branch
from
99273ae to
25e0255
Compare
jukkar
reviewed
Jan 30, 2024
rado17
force-pushed
the
wifi_dt_device
branch
from
25e0255 to
fa804c9
Compare
jukkar
approved these changes
Jan 30, 2024
sachinthegreen
approved these changes
Jan 31, 2024
krish2718
approved these changes
Jan 31, 2024
Wi-Fi device name has been updated to nrf_wlan0 after moving to devicetree based node creation. Modify the device name references used in send_event calls. Signed-off-by: Ravi Dondaputi <[email protected]>
rado17
force-pushed
the
wifi_dt_device
branch
from
fa804c9 to
61e332d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read device name from supplicant context instead of using hard-coded strings