This repository was archived by the owner on Nov 14, 2024. It is now read-only.
[nrf noup] zephyr: Fix handling of zero-byte receive #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixup! [nrf noup] zephyr: Add support for WPA CLI zephyr Sometimes even if the peer didn't close the socket, we still see zero byte receive, and un-registering for those cases causes the system to be broken. Handle the case by ignoring the current message but keeping the socket registered. Fixes SHEL-2283. Signed-off-by: Chaitanya Tata <[email protected]>
krish2718
requested review from
jukkar,
rado17,
sachinthegreen and
rlubos
as code owners
jukkar
approved these changes
Jan 23, 2024
sachinthegreen
approved these changes
Jan 23, 2024
rado17
approved these changes
Jan 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixup! [nrf noup] zephyr: Add support for WPA CLI zephyr
Sometimes even if the peer didn't close the socket, we still see zero byte receive, and un-registering for those cases causes the system to be broken.
Handle the case by ignoring the current message but keeping the socket registered.
Fixes SHEL-2283.