This repository has been archived by the owner on Nov 14, 2024. It is now read-only.
[nrf noup] zephyr: Fix possible race when getting scan results #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jukkar
requested review from
krish2718,
rado17,
sachinthegreen and
rlubos
as code owners
krish2718
approved these changes
Dec 4, 2023
The zephyr driver sets the scan_res2_get_in_prog flag to true after starting to get the results. This can cause possible race as the results might be done before the dev_ops->get_scan_results2() returns. This could lead to timeout in the following while loop. Signed-off-by: Jukka Rissanen <[email protected]>
|
Is the manifest changes really needed yet, the original fix is not yet merged and we do not reference that zephyrrtos repo yet in any manifest. |
jukkar
force-pushed
the
fix/race-in-scan-results
branch
from
c3de8a4 to
8fd6600
Compare
Yes, the manifest for |
jukkar
changed the title
rado17
approved these changes
Dec 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The zephyr driver sets the scan_res2_get_in_prog flag to true after starting to get the results. This can cause possible race as the results might be done before the dev_ops->get_scan_results2() returns. This could lead to timeout in the following while loop.