This repository has been archived by the owner on Nov 14, 2024. It is now read-only.
[nrf noup] zephyr: Fix MBO and GAS dependency #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krish2718
requested review from
jukkar,
rado17,
sachinthegreen and
rlubos
as code owners
krish2718
changed the title
krish2718
force-pushed
the
fix_mbo_gas
branch
from
42e2529 to
59b3031
Compare
fixup! [nrf noup] zephyr: Add support for Zephyr RTOS commit eb61195 ("[nrf fromlist] zephyr: Fix MBO build with GAS dependency") fixes the dependency in opensource acceptable way, but enable of GAS pulls in other modules costing memory. MBO uses GAS query only for HS2.0 which isn't enabled in Zephyr, so, instead of implicitly enabling GAS in Zephyr for MBO, we protect this code with GAS, which avoids pulling in code and saves memory. This was working till date because Zephyr toolchain silently removed the uncalled functions. In the future if we add support for HS2.0 then GAS will be automatically enabled and this still works. Signed-off-by: Chaitanya Tata <[email protected]>
krish2718
force-pushed
the
fix_mbo_gas
branch
from
59b3031 to
0daa951
Compare
sachinthegreen
approved these changes
Nov 28, 2023
rado17
approved these changes
Nov 29, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit eb61195 ("[nrf fromlist] zephyr: Fix MBO build with GAS dependency") fixes the dependency in opensource acceptable way, but enable of GAS pulls in other modules costing memory.
MBO uses GAS query only for HS2.0 which isn't enabled in Zephyr, so, instead of implicitly enabling GAS in Zephyr for MBO, we protect this code with GAS, which avoids pulling in code and saves memory.
This was working till date because Zephyr toolchain silently removed the uncalled functions.
In the future if we add support for HS2.0 then GAS will be automatically enabled and this still works.