Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nrf toup] Clear Thread Network after last fabric is removed #522

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

adigie
Copy link
Member

@adigie adigie commented Dec 6, 2024

Dataset has to be cleared to allow commissioning to different network when CONFIG_CHIP_LAST_FABRIC_REMOVED_ERASE_ONLY is used.

Dataset has to be cleared to allow commissioning to different network
when CONFIG_CHIP_LAST_FABRIC_REMOVED_ERASE_ONLY is used.

Signed-off-by: Adrian Gielniewski <[email protected]>
@doublemis1
Copy link
Contributor

It should be set as a backport (PR to nrf-sdk)

Copy link
Contributor

@ArekBalysNordic ArekBalysNordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and indeed missing there if we don't want to reset the device and clear RAM. In normal cases, the clearing process takes place only while commissioning in HandleRemoveNetwork right?

@ArekBalysNordic
Copy link
Contributor

It should be set as a backport (PR to nrf-sdk)

I guess we need to do it manually.

@maciejbaczmanski maciejbaczmanski added this to the 2.9.0 milestone Dec 10, 2024
@maciejbaczmanski maciejbaczmanski added the bug Something isn't working label Dec 10, 2024
@jukkar jukkar merged commit 20babbe into nrfconnect:master Dec 10, 2024
8 checks passed
@adigie adigie deleted the fix-factory-reset branch December 10, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants