Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nrf toup] config: nrfconnect: chip-module: Remove child/parent support #520

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[nrf toup] config: nrfconnect: chip-module: Remove child/parent support #520

wants to merge 1 commit into from

Conversation

nordicjm
Copy link
Contributor

@nordicjm nordicjm commented Dec 5, 2024

Removes support for child/parent images

!!!!!!!!!! Please delete the instructions below and replace with PR description

If you have an issue number, please use a syntax of
Fixes #12345 and a brief change description

If you do not have an issue number, please have a good description of
the problem and the fix. Help the reviewer understand what to expect.

Make sure you delete these instructions (to prove you have read them).

!!!!!!!!!! Instructions end

@github-actions github-actions bot added the config label Dec 5, 2024
This was referenced Dec 5, 2024
Closed
Open
@nordicjm nordicjm force-pushed the byebyechildparent branch 3 times, most recently from fe4035d to 35bd606 Compare December 11, 2024 08:25
@nordicjm nordicjm marked this pull request as ready for review December 11, 2024 13:43
kkasperczyk-no
kkasperczyk-no approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@kkasperczyk-no kkasperczyk-no left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ArekBalysNordic
ArekBalysNordic approved these changes Dec 12, 2024 •
edited
Loading
View reviewed changes
@nordicjm
[nrf toup] config: nrfconnect: chip-module: Remove child/parent support
1536794 
Removes support for child/parent images

Signed-off-by: Jamie McCrae <[email protected]>
@nordicjm nordicjm changed the title [nrf toup] config: nrfconnect: chip-module: Remoe child/parent support [nrf toup] config: nrfconnect: chip-module: Remove child/parent support Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArekBalysNordic ArekBalysNordic ArekBalysNordic approved these changes

@kkasperczyk-no kkasperczyk-no kkasperczyk-no approved these changes

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

Assignees
No one assigned
Labels
config
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nordicjm @kkasperczyk-no @ArekBalysNordic